Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 1100673004: Remove references to WebMidiClientMock from content/. (Closed)

Created:
5 years, 8 months ago by mlamouri (slow - plz ping)
Modified:
5 years, 8 months ago
Reviewers:
Mike West
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-shell_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove references to WebMidiClientMock from content/. It was only used for permissions mocking and there is a new TestRunner API that handles this. This CL is part of a suite of four patches: Part 1: https://codereview.chromium.org/1100843003 Part 2: <this> Part 3: https://codereview.chromium.org/1097933006 Part 4: https://codereview.chromium.org/1095233005 BUG=475141 Committed: https://crrev.com/835cbf31ec2e797407306b672cb33dd2d60e5cdd Cr-Commit-Position: refs/heads/master@{#326491}

Patch Set 1 #

Patch Set 2 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -31 lines) Patch
M content/shell/renderer/test_runner/test_runner.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/renderer/test_runner/test_runner.cc View 1 3 chunks +0 lines, -8 lines 0 comments Download
M content/shell/renderer/test_runner/web_frame_test_proxy.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/shell/renderer/test_runner/web_test_proxy.h View 4 chunks +0 lines, -5 lines 0 comments Download
M content/shell/renderer/test_runner/web_test_proxy.cc View 4 chunks +0 lines, -13 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
mlamouri (slow - plz ping)
Mike, I've heard you like line removals so I have a few for you here.
5 years, 8 months ago (2015-04-22 14:41:57 UTC) #2
Mike West
LGTM! More deletions!
5 years, 8 months ago (2015-04-22 14:50:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1100673004/20001
5 years, 8 months ago (2015-04-23 10:03:42 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-23 10:46:13 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-23 10:47:22 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/835cbf31ec2e797407306b672cb33dd2d60e5cdd
Cr-Commit-Position: refs/heads/master@{#326491}

Powered by Google App Engine
This is Rietveld 408576698