Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Issue 1099673002: Prepare Push Messaging browser tests for the endpoint value change. (Closed)

Created:
5 years, 8 months ago by Peter Beverloo
Modified:
5 years, 7 months ago
CC:
chromium-reviews, mvanouwerkerk+watch_chromium.org, peter+watch_chromium.org, johnme+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prepare Push Messaging browser tests for the endpoint value change. The subscriptionId property is being deprecated and its value will be appended to the actual push endpoint. This CL prepares the browser tests for this change, to make sure they don't break. This CL is part of a three-sided patch: [1] This CL. [2] https://codereview.chromium.org/1084683003/ [3] https://codereview.chromium.org/1078873004/ BUG=477401 Committed: https://crrev.com/bd88943c4c1605bbbf5e54e008f811aba3dd6539 Cr-Commit-Position: refs/heads/master@{#327918}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M chrome/browser/push_messaging/push_messaging_browsertest.cc View 1 3 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Peter Beverloo
+mvanouwerkerk
5 years, 8 months ago (2015-04-20 18:10:18 UTC) #2
Michael van Ouwerkerk
lgtm
5 years, 8 months ago (2015-04-21 11:02:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1099673002/1
5 years, 7 months ago (2015-05-01 15:08:25 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/48647) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 7 months ago (2015-05-01 15:11:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1099673002/20001
5 years, 7 months ago (2015-05-01 15:17:44 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-01 16:24:38 UTC) #11
commit-bot: I haz the power
5 years, 7 months ago (2015-05-01 16:25:46 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bd88943c4c1605bbbf5e54e008f811aba3dd6539
Cr-Commit-Position: refs/heads/master@{#327918}

Powered by Google App Engine
This is Rietveld 408576698