Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Unified Diff: chrome/browser/push_messaging/push_messaging_browsertest.cc

Issue 1099673002: Prepare Push Messaging browser tests for the endpoint value change. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/push_messaging/push_messaging_browsertest.cc
diff --git a/chrome/browser/push_messaging/push_messaging_browsertest.cc b/chrome/browser/push_messaging/push_messaging_browsertest.cc
index 5aafa7da3a7d824cc4a6ded437b9cafe2e09f4ad..c0cadf42fafd20e78d903d2fd08cf8bc48225a23 100644
--- a/chrome/browser/push_messaging/push_messaging_browsertest.cc
+++ b/chrome/browser/push_messaging/push_messaging_browsertest.cc
@@ -223,8 +223,9 @@ void PushMessagingBrowserTest::TryToSubscribeSuccessfully(
EXPECT_EQ("permission status - granted", script_result);
EXPECT_TRUE(RunScript("subscribePush()", &script_result));
- EXPECT_EQ(std::string(kPushMessagingEndpoint) + " - "
- + expected_push_subscription_id, script_result);
+
+ // TODO(peter): Add an EXPECT for the given endpoint after the value change
+ // has gone through.
}
PushMessagingApplicationId PushMessagingBrowserTest::GetServiceWorkerAppId(
@@ -263,7 +264,9 @@ IN_PROC_BROWSER_TEST_F(PushMessagingBrowserTest,
InfoBarResponder accepting_responder(GetInfoBarService(), true);
ASSERT_TRUE(RunScript("subscribePush()", &script_result));
- EXPECT_EQ(std::string(kPushMessagingEndpoint) + " - 1-0", script_result);
+
+ // TODO(peter): Add an EXPECT for the given endpoint after the value change
+ // has gone through.
PushMessagingApplicationId app_id = GetServiceWorkerAppId(0LL);
EXPECT_EQ(app_id.app_id_guid(), gcm_service()->last_registered_app_id());
@@ -587,7 +590,9 @@ IN_PROC_BROWSER_TEST_F(PushMessagingBrowserTest, PermissionStateSaysGranted) {
EXPECT_EQ("permission status - granted", script_result);
ASSERT_TRUE(RunScript("subscribePush()", &script_result));
- EXPECT_EQ(std::string(kPushMessagingEndpoint) + " - 1-0", script_result);
+
+ // TODO(peter): Add an EXPECT for the given endpoint after the value change
+ // has gone through.
ASSERT_TRUE(RunScript("permissionState()", &script_result));
EXPECT_EQ("permission status - granted", script_result);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698