Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1084683003: Merge the value of the push subscription id into the endpoint. (Closed)

Created:
5 years, 8 months ago by Peter Beverloo
Modified:
5 years, 7 months ago
CC:
blink-reviews, johnme+watch_chromium.org, mvanouwerkerk+watch_chromium.org, peter+watch_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Merge the value of the push subscription id into the endpoint. This change merges the subscription id belonging to a push subscription into the endpoint, and deprecates the subscriptionId attribute. The change is part of the following Intent to Deprecate thread: https://groups.google.com/a/chromium.org/d/topic/blink-dev/CK13omVO5ds/discussion When developers access the subscriptionId after all, they will get a deprecation warning shown in their console: > 'PushSubscription.subscriptionId' is deprecated and is now included in > 'PushSubscription.endpoint'. It will be removed in Chrome 45, around > August 2015. This CL is part of a three-sided patch: [1] https://codereview.chromium.org/1099673002/ [2] This CL. [3] https://codereview.chromium.org/1078873004/ BUG=477401 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194922

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -6 lines) Patch
M LayoutTests/http/tests/push_messaging/subscribe-success-in-document.html View 1 2 1 chunk +7 lines, -2 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M Source/modules/push_messaging/PushSubscription.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/push_messaging/PushSubscription.cpp View 2 chunks +9 lines, -2 lines 0 comments Download
M Source/modules/push_messaging/PushSubscription.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
Peter Beverloo
+mvanouwerkerk
5 years, 8 months ago (2015-04-20 18:10:28 UTC) #2
Peter Beverloo
Also +mkwst for the deprecation addition. This is blocked on the Intent to Deprecate. (Which ...
5 years, 8 months ago (2015-04-20 18:11:18 UTC) #4
Mike West
LGTM, but please wait for that thread to resolve.
5 years, 8 months ago (2015-04-20 18:20:59 UTC) #5
Michael van Ouwerkerk
lgtm
5 years, 8 months ago (2015-04-21 11:03:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1084683003/40001
5 years, 7 months ago (2015-05-05 12:11:21 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/builds/43860)
5 years, 7 months ago (2015-05-05 12:13:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1084683003/60001
5 years, 7 months ago (2015-05-05 12:19:34 UTC) #14
commit-bot: I haz the power
5 years, 7 months ago (2015-05-05 13:40:20 UTC) #15
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194922

Powered by Google App Engine
This is Rietveld 408576698