Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 1078873004: Address the TODOs in the PushMessagingBrowserTest for the endpoint merge. (Closed)

Created:
5 years, 8 months ago by Peter Beverloo
Modified:
5 years, 7 months ago
CC:
chromium-reviews, mvanouwerkerk+watch_chromium.org, peter+watch_chromium.org, johnme+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@push-subscriptionId
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Address the TODOs in the PushMessagingBrowserTest for the endpoint merge. The endpoint value checks have been put back in place, now following the new format and only checking the |endpoint| value. Inclusion of the subscription Id in the endpoint is covered by Blink's layout tests. This CL is part of a three-sided patch: [1] https://codereview.chromium.org/1099673002/ [2] https://codereview.chromium.org/1084683003/ [3] This CL. BUG=477401 Committed: https://crrev.com/7015c4d2419cd07f4643dd33321991ee81dcb6a2 Cr-Commit-Position: refs/heads/master@{#328523}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M chrome/browser/push_messaging/push_messaging_browsertest.cc View 1 4 chunks +10 lines, -9 lines 0 comments Download
M chrome/test/data/push_messaging/push_test.js View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Peter Beverloo
+mvanouwerkerk
5 years, 8 months ago (2015-04-20 18:10:39 UTC) #2
Michael van Ouwerkerk
lgtm
5 years, 8 months ago (2015-04-21 11:03:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1078873004/20001
5 years, 7 months ago (2015-05-06 12:43:46 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-06 13:41:37 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-06 13:42:43 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7015c4d2419cd07f4643dd33321991ee81dcb6a2
Cr-Commit-Position: refs/heads/master@{#328523}

Powered by Google App Engine
This is Rietveld 408576698