Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1097273002: Refactor core/v8/* methods to take isolate as first parameter (Closed)

Created:
5 years, 8 months ago by deepak.s
Modified:
5 years, 8 months ago
Reviewers:
haraken
CC:
blink-reviews, caseq+blink_chromium.org, arv+blink, blink-reviews-style_chromium.org, vivekg_samsung, vivekg, yurys+blink_chromium.org, lushnikov+blink_chromium.org, loislo+blink_chromium.org, pfeldman+blink_chromium.org, blink-reviews-bindings_chromium.org, devtools-reviews_chromium.org, apavlov+blink_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Refactor core/v8/* methods to take isolate as first parameter Refactor various methods in bindings/core/v8 to accept isolate as first parameter as v8::Isolate* is now manadatory. BUG=424446 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194128

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -27 lines) Patch
M Source/bindings/core/v8/NPV8Object.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/core/v8/V8Initializer.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/V8NPObject.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/bindings/core/v8/V8ValueCache.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/custom/V8CustomEventCustom.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/core/v8/custom/V8DevToolsHostCustom.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/core/v8/custom/V8InjectedScriptHostCustom.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/custom/V8InjectedScriptManager.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
deepak.s
PTAL?
5 years, 8 months ago (2015-04-21 10:53:24 UTC) #2
haraken
LGTM
5 years, 8 months ago (2015-04-21 10:54:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1097273002/1
5 years, 8 months ago (2015-04-21 11:33:36 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-21 14:04:53 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194128

Powered by Google App Engine
This is Rietveld 408576698