Refactor core/v8/* methods to take isolate as first parameter

Source/bindings/core/v8/custom/V8DevToolsHostCustom.cpp

 /*
  * Copyright (C) 2007-2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 38 matching lines @@
 {
 #if OS(MACOSX)
     v8SetReturnValue(info, v8AtomicString(info.GetIsolate(), "mac"));
 #elif OS(WIN)
     v8SetReturnValue(info, v8AtomicString(info.GetIsolate(), "windows"));
 #else // Unix-like systems
     v8SetReturnValue(info, v8AtomicString(info.GetIsolate(), "linux"));
 #endif
 }
 
-static bool populateContextMenuItems(const v8::Local<v8::Array>& itemArray, ContextMenu& menu, v8::Isolate* isolate)
+static bool populateContextMenuItems(v8::Isolate* isolate, const v8::Local<v8::Array>& itemArray, ContextMenu& menu)
 {
     v8::Local<v8::Context> context = isolate->GetCurrentContext();
     for (size_t i = 0; i < itemArray->Length(); ++i) {
         v8::Local<v8::Object> item = itemArray->Get(context, i).ToLocalChecked().As<v8::Object>();
         v8::Local<v8::Value> type;
         v8::Local<v8::Value> id;
         v8::Local<v8::Value> label;
         v8::Local<v8::Value> enabled;
         v8::Local<v8::Value> checked;
         v8::Local<v8::Value> subItems;
         if (!item->Get(context, v8AtomicString(isolate, "type")).ToLocal(&type)
             || !item->Get(context, v8AtomicString(isolate, "id")).ToLocal(&id)
             || !item->Get(context, v8AtomicString(isolate, "label")).ToLocal(&label)
             || !item->Get(context, v8AtomicString(isolate, "enabled")).ToLocal(&enabled)
             || !item->Get(context, v8AtomicString(isolate, "checked")).ToLocal(&checked)
             || !item->Get(context, v8AtomicString(isolate, "subItems")).ToLocal(&subItems))
             return false;
         if (!type->IsString())
             continue;
         String typeString = toCoreStringWithNullCheck(type.As<v8::String>());
         if (typeString == "separator") {
             ContextMenuItem item(ContextMenuItem(SeparatorType,
                 ContextMenuItemCustomTagNoAction,
                 String(),
                 String()));
             menu.appendItem(item);
         } else if (typeString == "subMenu" && subItems->IsArray()) {
             ContextMenu subMenu;
             v8::Local<v8::Array> subItemsArray = v8::Local<v8::Array>::Cast(subItems);
-            if (!populateContextMenuItems(subItemsArray, subMenu, isolate))
+            if (!populateContextMenuItems(isolate, subItemsArray, subMenu))
                 return false;
             TOSTRING_DEFAULT(V8StringResource<TreatNullAsNullString>, labelString, label, false);
             ContextMenuItem item(SubmenuType,
                 ContextMenuItemCustomTagNoAction,
                 labelString,
                 String(),
                 &subMenu);
             menu.appendItem(item);
         } else {
             int32_t int32Id;
@@ skipping 20 matching lines @@
     v8::Local<v8::Object> eventWrapper = v8::Local<v8::Object>::Cast(info[0]);
     if (!V8MouseEvent::wrapperTypeInfo.equals(toWrapperTypeInfo(eventWrapper)))
         return;
 
     Event* event = V8Event::toImpl(eventWrapper);
     if (!info[1]->IsArray())
         return;
 
     v8::Local<v8::Array> array = v8::Local<v8::Array>::Cast(info[1]);
     ContextMenu menu;
-    if (!populateContextMenuItems(array, menu, info.GetIsolate()))
+    if (!populateContextMenuItems(info.GetIsolate(), array, menu))
         return;
 
     DevToolsHost* devtoolsHost = V8DevToolsHost::toImpl(info.Holder());
     Vector<ContextMenuItem> items = menu.items();
     devtoolsHost->showContextMenu(event, items);
 }
 
 void V8DevToolsHost::showContextMenuAtPointMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& info)
 {
     if (info.Length() < 3)
         return;
 
     ExceptionState exceptionState(ExceptionState::ExecutionContext, "showContextMenuAtPoint", "DevToolsHost", info.Holder(), info.GetIsolate());
 
     TONATIVE_VOID_EXCEPTIONSTATE(float, x, toRestrictedFloat(info.GetIsolate(), info[0], exceptionState), exceptionState);
     TONATIVE_VOID_EXCEPTIONSTATE(float, y, toRestrictedFloat(info.GetIsolate(), info[1], exceptionState), exceptionState);
 
     v8::Local<v8::Value> array = v8::Local<v8::Value>::Cast(info[2]);
     if (!array->IsArray())
         return;
     ContextMenu menu;
-    if (!populateContextMenuItems(v8::Local<v8::Array>::Cast(array), menu, info.GetIsolate()))
+    if (!populateContextMenuItems(info.GetIsolate(), v8::Local<v8::Array>::Cast(array), menu))
         return;
 
     Document* document = nullptr;
     if (info.Length() >= 4 && v8::Local<v8::Value>::Cast(info[3])->IsObject()) {
         v8::Local<v8::Object> documentWrapper = v8::Local<v8::Object>::Cast(info[3]);
         if (!V8HTMLDocument::wrapperTypeInfo.equals(toWrapperTypeInfo(documentWrapper)))
             return;
         document = V8HTMLDocument::toImpl(documentWrapper);
     } else {
         v8::Isolate* isolate = info.GetIsolate();
         v8::Local<v8::Object> windowWrapper = V8Window::findInstanceInPrototypeChain(isolate->GetEnteredContext()->Global(), isolate);
         if (windowWrapper.IsEmpty())
             return;
         DOMWindow* window = V8Window::toImpl(windowWrapper);
         document = window ? toLocalDOMWindow(window)->document() : nullptr;
     }
     if (!document || !document->frame())
         return;
 
     DevToolsHost* devtoolsHost = V8DevToolsHost::toImpl(info.Holder());
     Vector<ContextMenuItem> items = menu.items();
     devtoolsHost->showContextMenu(document->frame(), x, y, items);
 }
 
 } // namespace blink