Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Unified Diff: Source/bindings/core/v8/custom/V8CustomEventCustom.cpp

Issue 1097273002: Refactor core/v8/* methods to take isolate as first parameter (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/core/v8/custom/V8CustomEventCustom.cpp
diff --git a/Source/bindings/core/v8/custom/V8CustomEventCustom.cpp b/Source/bindings/core/v8/custom/V8CustomEventCustom.cpp
index 8a566575045c13d37246830af73af2f3ace9fcac..29f8d8e26a8d1a0f09c99721ac89f69890f91410 100644
--- a/Source/bindings/core/v8/custom/V8CustomEventCustom.cpp
+++ b/Source/bindings/core/v8/custom/V8CustomEventCustom.cpp
@@ -43,7 +43,7 @@
namespace blink {
-static v8::Local<v8::Value> cacheState(v8::Local<v8::Object> customEvent, v8::Local<v8::Value> detail, v8::Isolate* isolate)
+static v8::Local<v8::Value> cacheState(v8::Isolate* isolate, v8::Local<v8::Object> customEvent, v8::Local<v8::Value> detail)
{
V8HiddenValue::setHiddenValue(isolate, customEvent, V8HiddenValue::detail(isolate), detail);
return detail;
@@ -71,11 +71,11 @@ void V8CustomEvent::detailAttributeGetterCustom(const v8::PropertyCallbackInfo<v
if (event->serializedDetail()) {
result = event->serializedDetail()->deserialize();
- v8SetReturnValue(info, cacheState(info.Holder(), result, info.GetIsolate()));
+ v8SetReturnValue(info, cacheState(info.GetIsolate(), info.Holder(), result));
return;
}
- v8SetReturnValue(info, cacheState(info.Holder(), v8::Null(info.GetIsolate()), info.GetIsolate()));
+ v8SetReturnValue(info, cacheState(info.GetIsolate(), info.Holder(), v8::Null(info.GetIsolate())));
}
void V8CustomEvent::initCustomEventMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& info)

Powered by Google App Engine
This is Rietveld 408576698