Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Unified Diff: Source/bindings/core/v8/V8ValueCache.cpp

Issue 1097273002: Refactor core/v8/* methods to take isolate as first parameter (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/core/v8/V8ValueCache.cpp
diff --git a/Source/bindings/core/v8/V8ValueCache.cpp b/Source/bindings/core/v8/V8ValueCache.cpp
index 53be40eb5b389017e14452f1648e34214733bf39..43953f854cec240a0ade2d41a886b2e43601cdf3 100644
--- a/Source/bindings/core/v8/V8ValueCache.cpp
+++ b/Source/bindings/core/v8/V8ValueCache.cpp
@@ -54,7 +54,7 @@ StringCache::~StringCache()
m_stringCache.Clear();
}
-static v8::Local<v8::String> makeExternalString(const String& string, v8::Isolate* isolate)
+static v8::Local<v8::String> makeExternalString(v8::Isolate* isolate, const String& string)
{
if (string.is8Bit()) {
WebCoreStringResource8* stringResource = new WebCoreStringResource8(string);
@@ -113,7 +113,7 @@ v8::Local<v8::String> StringCache::createStringAndInsertIntoCache(v8::Isolate* i
ASSERT(!m_stringCache.Contains(stringImpl));
ASSERT(stringImpl->length());
- v8::Local<v8::String> newString = makeExternalString(String(stringImpl), isolate);
+ v8::Local<v8::String> newString = makeExternalString(isolate, String(stringImpl));
ASSERT(!newString.IsEmpty());
ASSERT(newString->Length());
« no previous file with comments | « Source/bindings/core/v8/V8NPObject.cpp ('k') | Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698