Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(892)

Issue 1095843003: [cros] Modify oobe/login tests to work with webview (Closed)

Created:
5 years, 8 months ago by Nikita (slow)
Modified:
5 years, 8 months ago
Reviewers:
Dmitry Polukhin
CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, Roman Sorokin (ftl)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[cros] Modify oobe/login tests to work with webview * Flip LoginMangerTest/OobeBaseTest default to use webview * Parametrized tests: KioskTest*, DeviceDisablingTest * Disabled for now: BootstrapTest, ProxyAuthOnUserBoardScreenTest, ForceMaximizeOnFirstRunTest, UserCloudPolicyManagerTest, BlockingLoginTest* BUG=477402 Committed: https://crrev.com/dca16e072415d31c5ce1529b5db95e8897430454 Cr-Commit-Position: refs/heads/master@{#326257}

Patch Set 1 #

Patch Set 2 : force webview #

Patch Set 3 : flip default #

Patch Set 4 : disable blocking test #

Total comments: 10

Patch Set 5 : review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -70 lines) Patch
M chrome/browser/chromeos/login/easy_unlock/bootstrap_browsertest.cc View 1 2 3 4 4 chunks +14 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/kiosk_browsertest.cc View 38 chunks +57 lines, -44 lines 0 comments Download
M chrome/browser/chromeos/login/login_manager_test.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/proxy_auth_dialog_browsertest.cc View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/test/oobe_base_test.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/wizard_controller_browsertest.cc View 1 2 3 4 2 chunks +3 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/policy/blocking_login_browsertest.cc View 1 2 3 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/chromeos/policy/force_maximize_on_first_run_chromeos_browsertest.cc View 1 2 3 4 4 chunks +12 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/policy/login_policy_test_base.h View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/chromeos/policy/login_policy_test_base.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_browsertest.cc View 1 2 3 4 2 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/chromeos/system/device_disabling_browsertest.cc View 5 chunks +11 lines, -4 lines 0 comments Download

Messages

Total messages: 21 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1095843003/1
5 years, 8 months ago (2015-04-17 18:41:37 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 8 months ago (2015-04-17 19:15:44 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1095843003/20001
5 years, 8 months ago (2015-04-21 07:53:07 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/48693)
5 years, 8 months ago (2015-04-21 12:02:45 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1095843003/60001
5 years, 8 months ago (2015-04-22 05:32:04 UTC) #10
Nikita (slow)
Dmitry, please take a look
5 years, 8 months ago (2015-04-22 05:58:02 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 8 months ago (2015-04-22 06:11:51 UTC) #14
Dmitry Polukhin
lgtm https://codereview.chromium.org/1095843003/diff/60001/chrome/browser/chromeos/login/easy_unlock/bootstrap_browsertest.cc File chrome/browser/chromeos/login/easy_unlock/bootstrap_browsertest.cc (right): https://codereview.chromium.org/1095843003/diff/60001/chrome/browser/chromeos/login/easy_unlock/bootstrap_browsertest.cc#newcode67 chrome/browser/chromeos/login/easy_unlock/bootstrap_browsertest.cc:67: set_use_webview(false); nit, you can make it initialize it ...
5 years, 8 months ago (2015-04-22 06:47:07 UTC) #15
Nikita (slow)
https://codereview.chromium.org/1095843003/diff/60001/chrome/browser/chromeos/login/easy_unlock/bootstrap_browsertest.cc File chrome/browser/chromeos/login/easy_unlock/bootstrap_browsertest.cc (right): https://codereview.chromium.org/1095843003/diff/60001/chrome/browser/chromeos/login/easy_unlock/bootstrap_browsertest.cc#newcode67 chrome/browser/chromeos/login/easy_unlock/bootstrap_browsertest.cc:67: set_use_webview(false); On 2015/04/22 06:47:07, Dmitry Polukhin wrote: > nit, ...
5 years, 8 months ago (2015-04-22 09:01:45 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1095843003/80001
5 years, 8 months ago (2015-04-22 09:04:02 UTC) #19
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 8 months ago (2015-04-22 09:41:28 UTC) #20
commit-bot: I haz the power
5 years, 8 months ago (2015-04-22 09:42:14 UTC) #21
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/dca16e072415d31c5ce1529b5db95e8897430454
Cr-Commit-Position: refs/heads/master@{#326257}

Powered by Google App Engine
This is Rietveld 408576698