chrome/browser/chromeos/login/wizard_controller_browsertest.cc - Issue 1095843003: [cros] Modify oobe/login tests to work with webview

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/wizard_controller_browsertest.cc

Issue 1095843003: [cros] Modify oobe/login tests to work with webview (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/test/oobe_base_test.cc ('k') | chrome/browser/chromeos/policy/blocking_login_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/wizard_controller_browsertest.cc

diff --git a/chrome/browser/chromeos/login/wizard_controller_browsertest.cc b/chrome/browser/chromeos/login/wizard_controller_browsertest.cc

index 3b71746928dbcf6dee190a24ac0c1e301d97be89..1d6f75ad8d5b9b57e6699290858b9d118a07cd90 100644

--- a/chrome/browser/chromeos/login/wizard_controller_browsertest.cc

+++ b/chrome/browser/chromeos/login/wizard_controller_browsertest.cc

@@ -1012,11 +1012,6 @@ class WizardControllerProxyAuthOnSigninTest

if (!GetParam())

local_state_dict.SetBoolean(prefs::kWebviewSigninDisabled, true);

- // TODO(paulmeyer): Re-enable webview version of this test

- // (drop this condition) once http://crbug.com/452452 is fixed.

- if (GetParam())

- local_state_dict.SetBoolean(prefs::kWebviewSigninDisabled, true);

CHECK(JSONFileValueSerializer(local_state_path)

.Serialize(local_state_dict));

}

@@ -1044,9 +1039,11 @@ IN_PROC_BROWSER_TEST_P(WizardControllerProxyAuthOnSigninTest,

auth_needed_waiter.Wait();

}

+// TODO(paulmeyer): Re-enable webview version of this test

+// (drop this condition) once http://crbug.com/452452 is fixed.

INSTANTIATE_TEST_CASE_P(WizardControllerProxyAuthOnSigninSuite,

WizardControllerProxyAuthOnSigninTest,

- testing::Bool());

+ testing::Values(false));

class WizardControllerKioskFlowTest : public WizardControllerFlowTest {

protected: