Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(758)

Unified Diff: chrome/browser/chromeos/login/proxy_auth_dialog_browsertest.cc

Issue 1095843003: [cros] Modify oobe/login tests to work with webview (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: review Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/proxy_auth_dialog_browsertest.cc
diff --git a/chrome/browser/chromeos/login/proxy_auth_dialog_browsertest.cc b/chrome/browser/chromeos/login/proxy_auth_dialog_browsertest.cc
index 3eef72f7496d7905ec0afda37cd508c0d36adbb2..9fb5726d429c3bc3bb5e436ce42c2fe6f4218528 100644
--- a/chrome/browser/chromeos/login/proxy_auth_dialog_browsertest.cc
+++ b/chrome/browser/chromeos/login/proxy_auth_dialog_browsertest.cc
@@ -68,9 +68,7 @@ class ProxyAuthOnUserBoardScreenTest
proxy_server_(net::SpawnedTestServer::TYPE_BASIC_AUTH_PROXY,
net::SpawnedTestServer::kLocalhost,
base::FilePath()) {
- // TODO(paulmeyer): Re-enable webview version of this test
- // (uncomment this line) once http://crbug.com/452452 is fixed.
- // set_use_webview(GetParam());
+ set_use_webview(GetParam());
}
~ProxyAuthOnUserBoardScreenTest() override {}
@@ -128,8 +126,10 @@ IN_PROC_BROWSER_TEST_P(ProxyAuthOnUserBoardScreenTest,
}
}
+// TODO(paulmeyer): Re-enable webview version of this test
+// (once http://crbug.com/452452 is fixed.
INSTANTIATE_TEST_CASE_P(ProxyAuthOnUserBoardScreenTestSuite,
ProxyAuthOnUserBoardScreenTest,
- testing::Bool());
+ testing::Values(false));
} // namespace chromeos
« no previous file with comments | « chrome/browser/chromeos/login/login_manager_test.cc ('k') | chrome/browser/chromeos/login/test/oobe_base_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698