chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_browsertest.cc - Issue 1095843003: [cros] Modify oobe/login tests to work with webview

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_browsertest.cc

Issue 1095843003: [cros] Modify oobe/login tests to work with webview (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/policy/login_policy_test_base.cc ('k') | chrome/browser/chromeos/system/device_disabling_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_browsertest.cc

diff --git a/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_browsertest.cc b/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_browsertest.cc

index fff003698e3e3ba65378d417d23a3314b15354de..f884b7d341115d494d187cf57e89795e8541c676 100644

--- a/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_browsertest.cc

+++ b/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_browsertest.cc

@@ -38,7 +38,7 @@ class UserCloudPolicyManagerTest : public LoginPolicyTestBase {

DISALLOW_COPY_AND_ASSIGN(UserCloudPolicyManagerTest);

};

-IN_PROC_BROWSER_TEST_F(UserCloudPolicyManagerTest, StartSession) {

+IN_PROC_BROWSER_TEST_P(UserCloudPolicyManagerTest, StartSession) {

const char* const kStartupURLs[] = {"chrome://policy", "chrome://about"};

SkipToLoginScreen();

@@ -61,4 +61,9 @@ IN_PROC_BROWSER_TEST_F(UserCloudPolicyManagerTest, StartSession) {

}

+// TODO(nkostylev): Fix this test for webview. http://crbug.com/477402

+INSTANTIATE_TEST_CASE_P(UserCloudPolicyManagerTestSuite,

+ UserCloudPolicyManagerTest,

+ testing::Values(false));

} // namespace policy