Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 10947047: Fix remaining cc files to compile with Clang (Closed)

Created:
8 years, 3 months ago by enne (OOO)
Modified:
8 years, 3 months ago
Reviewers:
jamesr
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

Fix remaining cc files to compile with Clang BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=158005

Patch Set 1 #

Patch Set 2 : All remaining files #

Total comments: 1

Patch Set 3 : Remove explicit #

Patch Set 4 : Rebased #

Patch Set 5 : Rebased against time changes, etc... #

Patch Set 6 : #

Patch Set 7 : Fix FakeCCDelayBasedTimeSource #

Unified diffs Side-by-side diffs Delta from patch set Stats (+462 lines, -101 lines) Patch
M cc/CCAnimationCurve.h View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/CCAnimationCurve.cpp View 1 chunk +10 lines, -0 lines 0 comments Download
M cc/CCDebugRectHistory.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M cc/CCDebugRectHistory.cpp View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M cc/CCDelayBasedTimeSource.h View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M cc/CCDelayBasedTimeSource.cpp View 1 2 3 4 3 chunks +14 lines, -0 lines 0 comments Download
M cc/CCDelegatedRendererLayerImpl.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M cc/CCDelegatedRendererLayerImpl.cpp View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
M cc/CCHeadsUpDisplayLayerImpl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/CCHeadsUpDisplayLayerImpl.cpp View 2 chunks +10 lines, -0 lines 0 comments Download
M cc/CCLayerImpl.h View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M cc/CCLayerImpl.cpp View 1 2 3 4 1 chunk +15 lines, -0 lines 0 comments Download
M cc/CCLayerTilingData.h View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/CCLayerTilingData.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M cc/CCScopedThreadProxy.h View 3 chunks +5 lines, -3 lines 0 comments Download
A cc/CCScopedThreadProxy.cpp View 1 chunk +21 lines, -0 lines 0 comments Download
M cc/CCSolidColorLayerImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/CCSolidColorLayerImpl.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M cc/CCThreadProxy.h View 1 2 3 4 1 chunk +2 lines, -4 lines 0 comments Download
M cc/CCThreadProxy.cpp View 1 2 3 4 1 chunk +9 lines, -0 lines 0 comments Download
M cc/CCThreadedTest.h View 1 2 3 4 5 chunks +11 lines, -8 lines 0 comments Download
M cc/CCThreadedTest.cpp View 1 2 3 4 2 chunks +15 lines, -1 line 0 comments Download
M cc/ContentLayerChromium.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/ContentLayerChromium.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M cc/HeadsUpDisplayLayerChromium.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/HeadsUpDisplayLayerChromium.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M cc/LayerChromium.h View 1 2 3 4 5 chunks +9 lines, -9 lines 0 comments Download
M cc/LayerChromium.cpp View 6 chunks +45 lines, -0 lines 0 comments Download
M cc/LayerTextureUpdater.h View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
A cc/LayerTextureUpdater.cpp View 1 2 3 1 chunk +25 lines, -0 lines 0 comments Download
M cc/ScrollbarLayerChromium.h View 2 chunks +4 lines, -1 line 0 comments Download
M cc/ScrollbarLayerChromium.cpp View 2 chunks +9 lines, -0 lines 0 comments Download
M cc/UnthrottledTextureUploader.h View 1 chunk +3 lines, -3 lines 0 comments Download
A cc/UnthrottledTextureUploader.cpp View 1 chunk +26 lines, -0 lines 0 comments Download
M cc/cc.gyp View 1 2 3 4 3 chunks +3 lines, -0 lines 0 comments Download
M cc/cc_tests.gyp View 1 2 3 4 2 chunks +3 lines, -0 lines 0 comments Download
M cc/test/CCSchedulerTestCommon.h View 1 2 3 4 5 6 5 chunks +13 lines, -19 lines 0 comments Download
A cc/test/CCSchedulerTestCommon.cpp View 1 2 3 4 5 6 1 chunk +75 lines, -0 lines 0 comments Download
M cc/test/CCTiledLayerTestCommon.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/CCTiledLayerTestCommon.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M cc/test/FakeCCLayerTreeHostClient.h View 1 chunk +2 lines, -6 lines 0 comments Download
A cc/test/FakeCCLayerTreeHostClient.cpp View 1 chunk +22 lines, -0 lines 0 comments Download
M cc/test/MockCCQuadCuller.h View 1 2 2 chunks +9 lines, -29 lines 0 comments Download
A cc/test/MockCCQuadCuller.cpp View 1 1 chunk +47 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
enne (OOO)
Apparently there were only a few files left, so I added the rest.
8 years, 3 months ago (2012-09-19 23:41:46 UTC) #1
jamesr
lgtm https://codereview.chromium.org/10947047/diff/2001/cc/test/MockCCQuadCuller.h File cc/test/MockCCQuadCuller.h (right): https://codereview.chromium.org/10947047/diff/2001/cc/test/MockCCQuadCuller.h#newcode21 cc/test/MockCCQuadCuller.h:21: explicit MockCCQuadCuller(CCQuadList& externalQuadList, CCSharedQuadStateList& externalSharedQuadStateList); can drop the ...
8 years, 3 months ago (2012-09-20 00:36:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/10947047/7001
8 years, 3 months ago (2012-09-20 16:23:40 UTC) #3
commit-bot: I haz the power
Failed to apply patch for cc/LayerTextureUpdater.h: While running patch -p1 --forward --force; patching file cc/LayerTextureUpdater.h ...
8 years, 3 months ago (2012-09-20 16:23:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/10947047/5003
8 years, 3 months ago (2012-09-20 17:07:55 UTC) #5
commit-bot: I haz the power
Failed to apply patch for cc/CCDelayBasedTimeSource.cpp: While running patch -p1 --forward --force; patching file cc/CCDelayBasedTimeSource.cpp ...
8 years, 3 months ago (2012-09-20 17:08:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/10947047/1033
8 years, 3 months ago (2012-09-20 18:29:31 UTC) #7
commit-bot: I haz the power
Presubmit check for 10947047-1033 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 3 months ago (2012-09-20 18:29:51 UTC) #8
commit-bot: I haz the power
8 years, 3 months ago (2012-09-20 18:32:41 UTC) #9

Powered by Google App Engine
This is Rietveld 408576698