Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 1092033004: Merge to XFA: Remove Release() combo patch. (Closed)

Created:
5 years, 8 months ago by Tom Sepez
Modified:
5 years, 8 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -138 lines) Patch
M core/include/fpdfapi/fpdf_pageobj.h View 2 chunks +1 line, -4 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page.cpp View 4 chunks +5 lines, -14 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_graph_state.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M core/src/fpdfdoc/doc_annot.cpp View 5 chunks +4 lines, -9 lines 0 comments Download
M fpdfsdk/include/formfiller/FFL_TextField.h View 2 chunks +1 line, -15 lines 0 comments Download
M fpdfsdk/include/fsdk_baseform.h View 1 chunk +9 lines, -14 lines 0 comments Download
M fpdfsdk/include/fxedit/fx_edit.h View 1 chunk +2 lines, -4 lines 0 comments Download
M fpdfsdk/include/fxedit/fxet_edit.h View 2 chunks +6 lines, -11 lines 0 comments Download
M fpdfsdk/src/formfiller/FFL_TextField.cpp View 1 chunk +0 lines, -29 lines 0 comments Download
M fpdfsdk/src/fsdk_baseform.cpp View 2 chunks +7 lines, -15 lines 0 comments Download
M fpdfsdk/src/fxedit/fxet_edit.cpp View 5 chunks +4 lines, -21 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Tom Sepez
Lei, for review. Probably too complicated to TBR.
5 years, 8 months ago (2015-04-20 22:24:24 UTC) #2
Lei Zhang
lgtm
5 years, 8 months ago (2015-04-20 22:37:38 UTC) #3
Tom Sepez
5 years, 8 months ago (2015-04-20 23:33:34 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ced4c2bf1d0d1bab14a6145b35b3baecb175a691 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698