Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 1097843003: Remove release method from CBA_AnnotItetator. (Closed)

Created:
5 years, 8 months ago by Tom Sepez
Modified:
5 years, 8 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove release method from CBA_AnnotItetator. Also remove virtual methods, since this is neither subclassed nor a subclass. BUG=https://code.google.com/p/pdfium/issues/detail?id=140 R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/19ae17578f99621100a26dac3e2c7c3dbf7c7cd1

Patch Set 1 #

Total comments: 2

Patch Set 2 : Untabify. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -29 lines) Patch
M fpdfsdk/include/fsdk_baseform.h View 1 chunk +9 lines, -14 lines 0 comments Download
M fpdfsdk/src/fsdk_baseform.cpp View 1 2 chunks +7 lines, -15 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Tom Sepez
Lei, for review.
5 years, 8 months ago (2015-04-20 18:12:58 UTC) #2
Lei Zhang
lgtm https://codereview.chromium.org/1097843003/diff/1/fpdfsdk/src/fsdk_baseform.cpp File fpdfsdk/src/fsdk_baseform.cpp (right): https://codereview.chromium.org/1097843003/diff/1/fpdfsdk/src/fsdk_baseform.cpp#newcode1734 fpdfsdk/src/fsdk_baseform.cpp:1734: if (bNext) { nit: Can we get rid ...
5 years, 8 months ago (2015-04-20 20:32:50 UTC) #3
Lei Zhang
The commit msg also has a typo for 'Iterator'
5 years, 8 months ago (2015-04-20 20:35:50 UTC) #4
Tom Sepez
https://codereview.chromium.org/1097843003/diff/1/fpdfsdk/src/fsdk_baseform.cpp File fpdfsdk/src/fsdk_baseform.cpp (right): https://codereview.chromium.org/1097843003/diff/1/fpdfsdk/src/fsdk_baseform.cpp#newcode1734 fpdfsdk/src/fsdk_baseform.cpp:1734: if (bNext) { On 2015/04/20 20:32:49, Lei Zhang wrote: ...
5 years, 8 months ago (2015-04-20 20:36:54 UTC) #5
Tom Sepez
5 years, 8 months ago (2015-04-20 20:38:44 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
19ae17578f99621100a26dac3e2c7c3dbf7c7cd1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698