Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 1093213002: Remove Release() from CPDF_PageObject (Closed)

Created:
5 years, 8 months ago by Tom Sepez
Modified:
5 years, 8 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Move dtor to .cpp file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -26 lines) Patch
M core/include/fpdfapi/fpdf_pageobj.h View 1 2 chunks +1 line, -4 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page.cpp View 1 4 chunks +5 lines, -14 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_graph_state.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M core/src/fpdfdoc/doc_annot.cpp View 5 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Tom Sepez
Lei.
5 years, 8 months ago (2015-04-20 18:31:31 UTC) #1
Tom Sepez
For review.
5 years, 8 months ago (2015-04-20 18:51:53 UTC) #3
Lei Zhang
LGTM I think you can write BUG=pdfium:140 instead of the full URL. https://codereview.chromium.org/1093213002/diff/1/core/include/fpdfapi/fpdf_pageobj.h File core/include/fpdfapi/fpdf_pageobj.h ...
5 years, 8 months ago (2015-04-20 19:21:59 UTC) #4
Tom Sepez
https://codereview.chromium.org/1093213002/diff/1/core/include/fpdfapi/fpdf_pageobj.h File core/include/fpdfapi/fpdf_pageobj.h (right): https://codereview.chromium.org/1093213002/diff/1/core/include/fpdfapi/fpdf_pageobj.h#newcode459 core/include/fpdfapi/fpdf_pageobj.h:459: virtual ~CPDF_PageObject() { } On 2015/04/20 19:21:59, Lei Zhang ...
5 years, 8 months ago (2015-04-20 19:29:01 UTC) #5
Tom Sepez
5 years, 8 months ago (2015-04-20 19:29:17 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
bc580c69403169afa656aabb06a56b26d3b729cf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698