Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 1098043002: Remove Release() from IFX_Edit_UndoItem. (Closed)

Created:
5 years, 8 months ago by Tom Sepez
Modified:
5 years, 8 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove Release() from IFX_Edit_UndoItem. Also delete unused CFFL_Edit_UndoItem class. BUG=https://code.google.com/p/pdfium/issues/detail?id=140 R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/a4fbc2814c231da29104bb8922811127a59bd6e7

Patch Set 1 #

Patch Set 2 : Tabify. #

Patch Set 3 : Add override keyword while we're at it. #

Patch Set 4 : Unused CFFL_Edit_UndoItem #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -80 lines) Patch
M fpdfsdk/include/formfiller/FFL_TextField.h View 1 2 3 2 chunks +1 line, -15 lines 0 comments Download
M fpdfsdk/include/fxedit/fx_edit.h View 1 1 chunk +2 lines, -4 lines 1 comment Download
M fpdfsdk/include/fxedit/fxet_edit.h View 1 2 2 chunks +6 lines, -11 lines 0 comments Download
M fpdfsdk/src/formfiller/FFL_TextField.cpp View 1 2 3 1 chunk +0 lines, -29 lines 0 comments Download
M fpdfsdk/src/fxedit/fxet_edit.cpp View 5 chunks +4 lines, -21 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Tom Sepez
Lei, more cleanup. Thanks.
5 years, 8 months ago (2015-04-20 19:11:49 UTC) #2
Lei Zhang
lgtm https://codereview.chromium.org/1098043002/diff/60001/fpdfsdk/include/fxedit/fx_edit.h File fpdfsdk/include/fxedit/fx_edit.h (right): https://codereview.chromium.org/1098043002/diff/60001/fpdfsdk/include/fxedit/fx_edit.h#newcode167 fpdfsdk/include/fxedit/fx_edit.h:167: virtual ~IFX_Edit_UndoItem() { } Impl to .cpp file, ...
5 years, 8 months ago (2015-04-20 19:31:37 UTC) #3
Tom Sepez
On 2015/04/20 19:31:37, Lei Zhang wrote: > lgtm > > https://codereview.chromium.org/1098043002/diff/60001/fpdfsdk/include/fxedit/fx_edit.h > File fpdfsdk/include/fxedit/fx_edit.h (right): ...
5 years, 8 months ago (2015-04-20 22:12:02 UTC) #4
Tom Sepez
5 years, 8 months ago (2015-04-20 22:12:43 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
a4fbc2814c231da29104bb8922811127a59bd6e7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698