Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 10915298: Add CCDelegatingRenderer, and corresponding IPCs (Closed)

Created:
8 years, 3 months ago by piman
Modified:
7 years, 8 months ago
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

Add CCDelegatingRenderer, and corresponding IPCs This is work in progress and doesn't do anything aside of sending empty IPCs, but hooks up the first pieces. BUG=146080

Patch Set 1 : correct base #

Total comments: 8

Patch Set 2 : Added a bunch of traits #

Patch Set 3 : rebase on top of https://codereview.chromium.org/11096035/ #

Patch Set 4 : merge fix #

Total comments: 2

Patch Set 5 : update following https://bugs.webkit.org/show_bug.cgi?id=98833 #

Patch Set 6 : rebase on top of https://bugs.webkit.org/show_bug.cgi?id=98841 #

Patch Set 7 : adding missing files #

Patch Set 8 : adding missing files #

Patch Set 9 : fix clang #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1585 lines, -114 lines) Patch
M cc/CCDelegatedRendererLayerImpl.h View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M cc/CCDelegatedRendererLayerImpl.cpp View 1 2 3 chunks +24 lines, -1 line 0 comments Download
A cc/CCDelegatingRenderer.h View 1 2 3 4 5 6 7 8 1 chunk +74 lines, -0 lines 0 comments Download
A cc/CCDelegatingRenderer.cpp View 1 2 3 4 5 6 7 8 1 chunk +237 lines, -0 lines 0 comments Download
M cc/CCDrawQuad.h View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M cc/CCFrameRateController.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M cc/CCHeadsUpDisplayLayerImpl.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M cc/CCLayerTreeHost.h View 1 2 2 chunks +1 line, -1 line 0 comments Download
M cc/CCLayerTreeHost.cpp View 1 2 3 chunks +2 lines, -2 lines 0 comments Download
M cc/CCLayerTreeHostImpl.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M cc/CCLayerTreeHostImpl.cpp View 1 2 3 4 5 4 chunks +12 lines, -1 line 0 comments Download
M cc/CCOcclusionTracker.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M cc/CCOcclusionTracker.cpp View 1 2 4 chunks +8 lines, -8 lines 0 comments Download
M cc/CCPrioritizedTextureManager.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M cc/CCQuadCuller.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M cc/CCRenderPass.h View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M cc/CCRenderPassDrawQuad.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M cc/CCRenderer.h View 1 2 3 4 5 2 chunks +6 lines, -0 lines 0 comments Download
M cc/CCRendererGL.cpp View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M cc/CCRendererSoftware.cpp View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M cc/CCResourceProvider.h View 1 2 3 4 4 chunks +8 lines, -22 lines 0 comments Download
M cc/CCResourceProvider.cpp View 1 2 3 4 14 chunks +32 lines, -41 lines 0 comments Download
M cc/CCResourceProviderTest.cpp View 1 2 3 4 5 chunks +13 lines, -9 lines 0 comments Download
M cc/CCSingleThreadProxy.cpp View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M cc/CCTextureDrawQuad.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M cc/CCTextureDrawQuad.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M cc/CCTileDrawQuad.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M cc/DelegatedRendererLayerChromium.h View 1 2 3 4 5 2 chunks +14 lines, -1 line 0 comments Download
M cc/DelegatedRendererLayerChromium.cpp View 1 2 3 4 5 3 chunks +135 lines, -2 lines 0 comments Download
M cc/ScrollbarLayerChromium.cpp View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M cc/TiledLayerChromium.cpp View 1 2 4 chunks +9 lines, -5 lines 0 comments Download
M cc/TreeSynchronizer.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M cc/cc.gyp View 1 2 3 4 5 3 chunks +37 lines, -0 lines 0 comments Download
A cc/compositor_frame.h View 1 2 3 4 5 1 chunk +37 lines, -0 lines 0 comments Download
A cc/compositor_frame.cc View 1 2 3 4 5 6 1 chunk +21 lines, -0 lines 0 comments Download
A cc/ipc/cc_param_traits.h View 1 2 3 4 5 1 chunk +41 lines, -0 lines 0 comments Download
A cc/ipc/cc_param_traits.cc View 1 2 3 4 5 1 chunk +82 lines, -0 lines 0 comments Download
A cc/ipc/cc_render_pass_traits.h View 1 2 1 chunk +100 lines, -0 lines 0 comments Download
A cc/ipc/cc_render_pass_traits.cc View 1 2 3 4 5 1 chunk +392 lines, -0 lines 0 comments Download
A cc/transferable_resource.h View 1 2 3 4 5 1 chunk +42 lines, -0 lines 0 comments Download
A cc/transferable_resource.cc View 1 2 3 4 5 6 1 chunk +24 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.h View 1 2 3 4 5 3 chunks +8 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 2 3 4 5 2 chunks +18 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 2 3 4 5 3 chunks +5 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 2 3 4 5 1 chunk +34 lines, -0 lines 0 comments Download
A + content/common/gpu/client/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/view_messages.h View 1 2 3 4 5 3 chunks +19 lines, -0 lines 0 comments Download
M content/content_common.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/port/browser/render_widget_host_view_port.h View 1 2 3 4 5 2 chunks +8 lines, -2 lines 0 comments Download
M content/public/common/content_switches.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/gpu/compositor_output_surface.h View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M content/renderer/gpu/compositor_output_surface.cc View 1 2 3 4 5 6 chunks +25 lines, -4 lines 0 comments Download
M ui/compositor/layer.h View 1 2 3 4 5 6 7 8 4 chunks +9 lines, -0 lines 0 comments Download
M ui/compositor/layer.cc View 1 2 3 4 2 chunks +45 lines, -0 lines 0 comments Download
M webkit/compositor_bindings/WebDelegatedRendererLayerImpl.h View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M webkit/compositor_bindings/WebDelegatedRendererLayerImpl.cpp View 1 2 3 4 5 2 chunks +12 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
piman
FYI, this is work in progress, but is where I'm going. With this I can ...
8 years, 3 months ago (2012-09-15 02:45:38 UTC) #1
danakj
This is cool! I have some questions about it all for you. https://codereview.chromium.org/10915298/diff/2001/cc/CCDelegatingRenderer.cpp File cc/CCDelegatingRenderer.cpp ...
8 years, 3 months ago (2012-09-21 20:51:41 UTC) #2
piman
2 notes: - this isn't intended for landing yet, just to show the direction for ...
8 years, 3 months ago (2012-09-21 22:02:12 UTC) #3
jam
https://codereview.chromium.org/10915298/diff/2001/content/common/gpu/client/cc_param_traits.h File content/common/gpu/client/cc_param_traits.h (right): https://codereview.chromium.org/10915298/diff/2001/content/common/gpu/client/cc_param_traits.h#newcode14 content/common/gpu/client/cc_param_traits.h:14: struct WebCompositorFrameAck; I can't find these structs, so I ...
8 years, 3 months ago (2012-09-24 18:25:36 UTC) #4
piman
On Mon, Sep 24, 2012 at 11:25 AM, <jam@chromium.org> wrote: > > https://codereview.chromium.**org/10915298/diff/2001/** > content/common/gpu/client/cc_**param_traits.h<https://codereview.chromium.org/10915298/diff/2001/content/common/gpu/client/cc_param_traits.h> ...
8 years, 3 months ago (2012-09-24 19:59:29 UTC) #5
jam
On 2012/09/24 19:59:29, piman wrote: > On Mon, Sep 24, 2012 at 11:25 AM, <mailto:jam@chromium.org> ...
8 years, 3 months ago (2012-09-24 20:45:01 UTC) #6
aelias_OOO_until_Jul13
https://codereview.chromium.org/10915298/diff/16001/cc/transferable_resource.h File cc/transferable_resource.h (right): https://codereview.chromium.org/10915298/diff/16001/cc/transferable_resource.h#newcode28 cc/transferable_resource.h:28: struct TransferableResourceList { Clang builds fail, complaining this needs ...
8 years, 2 months ago (2012-10-10 00:16:17 UTC) #7
aelias_OOO_until_Jul13
https://codereview.chromium.org/10915298/diff/16001/cc/web_compositor_frame.h File cc/web_compositor_frame.h (right): https://codereview.chromium.org/10915298/diff/16001/cc/web_compositor_frame.h#newcode19 cc/web_compositor_frame.h:19: struct WebCompositorFrame { Let's define these as empty classes ...
8 years, 2 months ago (2012-10-10 00:47:25 UTC) #8
piman
On 2012/10/10 00:16:17, aelias wrote: > https://codereview.chromium.org/10915298/diff/16001/cc/transferable_resource.h > File cc/transferable_resource.h (right): > > https://codereview.chromium.org/10915298/diff/16001/cc/transferable_resource.h#newcode28 > ...
8 years, 2 months ago (2012-10-10 02:13:26 UTC) #9
piman
8 years, 2 months ago (2012-10-10 02:16:52 UTC) #10
On 2012/10/10 00:47:25, aelias wrote:
> https://codereview.chromium.org/10915298/diff/16001/cc/web_compositor_frame.h
> File cc/web_compositor_frame.h (right):
> 
>
https://codereview.chromium.org/10915298/diff/16001/cc/web_compositor_frame.h...
> cc/web_compositor_frame.h:19: struct WebCompositorFrame {
> Let's define these as empty classes in WebKit tree (without a virtual
destructor
> either), and have these be a subclass.  Similarly for TransferableResource and
> TransferableResourceList.  Traits would also work on the subclass only.

I did https://bugs.webkit.org/show_bug.cgi?id=98841 for that and take in latest
patch. Note that TransferableResource doesn't need to be in webkit (only
TransferableResourceList).

Powered by Google App Engine
This is Rietveld 408576698