Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 109033002: Shut up the CoreText performance note. (Closed)

Created:
7 years ago by mtklein
Modified:
7 years ago
Reviewers:
bungeman-skia, reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : ref ALL the things #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M src/ports/SkFontHost_mac.cpp View 1 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
mtklein
7 years ago (2013-12-06 22:02:09 UTC) #1
bungeman-skia
https://codereview.chromium.org/109033002/diff/1/src/ports/SkFontHost_mac.cpp File src/ports/SkFontHost_mac.cpp (right): https://codereview.chromium.org/109033002/diff/1/src/ports/SkFontHost_mac.cpp#newcode2110 src/ports/SkFontHost_mac.cpp:2110: CTFontDescriptorRef descriptor = CTFontDescriptorCreateWithAttributes( This create, I'm fairly certain, ...
7 years ago (2013-12-09 15:46:12 UTC) #2
mtklein
have a look?
7 years ago (2013-12-10 16:02:57 UTC) #3
bungeman-skia
If it doesn't break anything, lgtm.
7 years ago (2013-12-10 16:13:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/109033002/20001
7 years ago (2013-12-10 16:14:58 UTC) #5
commit-bot: I haz the power
Change committed as 12599
7 years ago (2013-12-10 16:27:47 UTC) #6
mtklein
7 years ago (2013-12-10 17:08:39 UTC) #7
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/111853003/ by mtklein@google.com.

The reason for reverting is: I suspect this is causing GM to crash on Mac..

Powered by Google App Engine
This is Rietveld 408576698