Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(944)

Unified Diff: src/ports/SkFontHost_mac.cpp

Issue 109033002: Shut up the CoreText performance note. (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: ref ALL the things Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ports/SkFontHost_mac.cpp
diff --git a/src/ports/SkFontHost_mac.cpp b/src/ports/SkFontHost_mac.cpp
index 3c1a274887728feebe9570ce5f4c0ce56eae247f..fe3fd069817be56a3406d2b03c57ca7882812e91 100755
--- a/src/ports/SkFontHost_mac.cpp
+++ b/src/ports/SkFontHost_mac.cpp
@@ -2107,7 +2107,13 @@ static SkTypeface* createFromDesc(CFStringRef cfFamilyName,
return face;
}
- AutoCFRelease<CTFontRef> ctNamed(CTFontCreateWithName(cfFamilyName, 1, NULL));
+ AutoCFRelease<CFDictionaryRef> fontFamilyNameDictionary(
+ CFDictionaryCreate(kCFAllocatorDefault,
+ (const void**)&kCTFontFamilyNameAttribute, (const void**)&cfFamilyName,
+ 1, &kCFTypeDictionaryKeyCallBacks, &kCFTypeDictionaryValueCallBacks));
+ AutoCFRelease<CTFontDescriptorRef> fontDescriptor(
+ CTFontDescriptorCreateWithAttributes(fontFamilyNameDictionary));
+ AutoCFRelease<CTFontRef> ctNamed(CTFontCreateWithFontDescriptor(fontDescriptor, 0, NULL));
CTFontRef ctFont = CTFontCreateCopyWithAttributes(ctNamed, 1, NULL, desc);
if (NULL == ctFont) {
return NULL;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698