Shut up the CoreText performance note.

src/ports/SkFontHost_mac.cpp

 
 /*
  * Copyright 2006 The Android Open Source Project
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include <vector>
 #ifdef SK_BUILD_FOR_MAC
@@ skipping 2089 matching lines @@
     NameFontStyleRec rec;
     CFStringToSkString(cfFamilyName, &rec.fFamilyName);
     rec.fFontStyle = desc2fontstyle(desc);
 
     SkTypeface* face = SkTypefaceCache::FindByProcAndRef(nameFontStyleProc,
                                                          &rec);
     if (face) {
         return face;
     }
 
-    AutoCFRelease<CTFontRef> ctNamed(CTFontCreateWithName(cfFamilyName, 1, NULL));
+    CTFontDescriptorRef descriptor = CTFontDescriptorCreateWithAttributes(

[bungeman-skia, 2013/12/09 15:46:12]

This create, I'm fairly certain, needs to be unref'ed and also the CFDictionary
on the line below. Unless the other calls take the ref, but that seems unlikely.

In fact, that's what the code you lifted from does, the QCFType is the more
generic version of AutoCFRelease here.

+        CFDictionaryCreate(kCFAllocatorDefault,
+                           (const void**)&kCTFontFamilyNameAttribute, (const void**)&cfFamilyName,
+                            1, &kCFTypeDictionaryKeyCallBacks, &kCFTypeDictionaryValueCallBacks));
+    AutoCFRelease<CTFontRef> ctNamed(CTFontCreateWithFontDescriptor(descriptor, 0, NULL));
     CTFontRef ctFont = CTFontCreateCopyWithAttributes(ctNamed, 1, NULL, desc);
     if (NULL == ctFont) {
         return NULL;
     }
 
     SkString str;
     CFStringToSkString(cfFamilyName, &str);
 
     bool isFixedPitch;
     (void)computeStyleBits(ctFont, &isFixedPitch);
@@ skipping 186 matching lines @@
         return create_typeface(NULL, familyName, (SkTypeface::Style)styleBits);
     }
 };
 
 ///////////////////////////////////////////////////////////////////////////////
 
 SkFontMgr* SkFontMgr::Factory() {
     return SkNEW(SkFontMgr_Mac);
 }
 #endif