Implements determineAccessibilityRole() instead of roleValue()

Implements determineAccessibilityRole() instead of roleValue()

This patch removes roleValue() from the child classes of AXLayoutObject
and implements determineAccessibilityRole(). It is called
at AXNodeObject::init() and AXNodeObject::updateAccessibilityRole() and
decides the proper AX roles. The child classes of AXLayoutObject set
the role using it and AXObject::roleValue() is called naturally to get that role.

BUG=467434
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193783

[je_julie(Not used), 2015-04-14 23:21:04]

je_julie.kim@samsung.com changed reviewers:
+ dmazzoni@chromium.org

[je_julie(Not used), 2015-04-14 23:22:45]

Hi Dominic,

This patch removes roleValue() from
- AXSlider
- AXProgressIndicator
- AXMenuList
- AXListBoxOption
- AXListBox.
They will use determineAccessibilityRole() instead of it.
From the CL, https://codereview.chromium.org/1004803004,
I tried to keep roleValue() and added handling role attribute.
While I'm looking into role decision,
I feel that it's more natural to use determineAccessibilityRole()
, remove roleValue() and use AXObject::roleValue() to get the role.
WDYT?

Test for this patch is covered with role-attribute.html and
presentation-owned-elements.html in LayoutTest.
PTAL.

[dmazzoni, 2015-04-15 06:23:58]

lgtm

I agree, it makes more sense to override determineAccessibilityRole. Thanks!

[je_julie(Not used), 2015-04-15 09:33:46]

The CQ bit was checked by je_julie.kim@samsung.com

[commit-bot: I haz the power, 2015-04-15 09:34:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1088853003/1

[commit-bot: I haz the power, 2015-04-15 11:38:04]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193783