Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Side by Side Diff: Source/modules/accessibility/AXSlider.cpp

Issue 1088853003: Implements determineAccessibilityRole() instead of roleValue() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/modules/accessibility/AXSlider.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Apple Inc. All rights reserved. 2 * Copyright (C) 2009 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 AXSlider::AXSlider(LayoutObject* layoutObject, AXObjectCacheImpl* axObjectCache) 42 AXSlider::AXSlider(LayoutObject* layoutObject, AXObjectCacheImpl* axObjectCache)
43 : AXLayoutObject(layoutObject, axObjectCache) 43 : AXLayoutObject(layoutObject, axObjectCache)
44 { 44 {
45 } 45 }
46 46
47 PassRefPtr<AXSlider> AXSlider::create(LayoutObject* layoutObject, AXObjectCacheI mpl* axObjectCache) 47 PassRefPtr<AXSlider> AXSlider::create(LayoutObject* layoutObject, AXObjectCacheI mpl* axObjectCache)
48 { 48 {
49 return adoptRef(new AXSlider(layoutObject, axObjectCache)); 49 return adoptRef(new AXSlider(layoutObject, axObjectCache));
50 } 50 }
51 51
52 AccessibilityRole AXSlider::roleValue() const 52 AccessibilityRole AXSlider::determineAccessibilityRole()
53 { 53 {
54 AccessibilityRole ariaRole = ariaRoleAttribute(); 54 if ((m_ariaRole = determineAriaRoleAttribute()) != UnknownRole)
55 if (ariaRole != UnknownRole) 55 return m_ariaRole;
56 return ariaRole; 56
57 return SliderRole; 57 return SliderRole;
58 } 58 }
59 59
60 AccessibilityOrientation AXSlider::orientation() const 60 AccessibilityOrientation AXSlider::orientation() const
61 { 61 {
62 // Default to horizontal in the unknown case. 62 // Default to horizontal in the unknown case.
63 if (!m_layoutObject) 63 if (!m_layoutObject)
64 return AccessibilityOrientationHorizontal; 64 return AccessibilityOrientationHorizontal;
65 65
66 const ComputedStyle* style = m_layoutObject->style(); 66 const ComputedStyle* style = m_layoutObject->style();
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
158 return LayoutRect(); 158 return LayoutRect();
159 return toElement(sliderLayoutObject->node())->closedShadowRoot()->getElement ById(ShadowElementNames::sliderThumb())->boundingBox(); 159 return toElement(sliderLayoutObject->node())->closedShadowRoot()->getElement ById(ShadowElementNames::sliderThumb())->boundingBox();
160 } 160 }
161 161
162 bool AXSliderThumb::computeAccessibilityIsIgnored() const 162 bool AXSliderThumb::computeAccessibilityIsIgnored() const
163 { 163 {
164 return accessibilityIsIgnoredByDefault(); 164 return accessibilityIsIgnoredByDefault();
165 } 165 }
166 166
167 } // namespace blink 167 } // namespace blink
OLDNEW
« no previous file with comments | « Source/modules/accessibility/AXSlider.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698