Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1065)

Unified Diff: Source/modules/accessibility/AXMenuList.cpp

Issue 1088853003: Implements determineAccessibilityRole() instead of roleValue() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/accessibility/AXMenuList.h ('k') | Source/modules/accessibility/AXProgressIndicator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/accessibility/AXMenuList.cpp
diff --git a/Source/modules/accessibility/AXMenuList.cpp b/Source/modules/accessibility/AXMenuList.cpp
index f21b0f6f5b083b96af8c27e1257e7432f9a90ec6..cc9f19efffd68ff55ac11bb5ea4e7bb93294803c 100644
--- a/Source/modules/accessibility/AXMenuList.cpp
+++ b/Source/modules/accessibility/AXMenuList.cpp
@@ -42,11 +42,11 @@ PassRefPtr<AXMenuList> AXMenuList::create(LayoutMenuList* layoutObject, AXObject
return adoptRef(new AXMenuList(layoutObject, axObjectCache));
}
-AccessibilityRole AXMenuList::roleValue() const
+AccessibilityRole AXMenuList::determineAccessibilityRole()
{
- AccessibilityRole ariaRole = ariaRoleAttribute();
- if (ariaRole != UnknownRole)
- return ariaRole;
+ if ((m_ariaRole = determineAriaRoleAttribute()) != UnknownRole)
+ return m_ariaRole;
+
return PopUpButtonRole;
}
« no previous file with comments | « Source/modules/accessibility/AXMenuList.h ('k') | Source/modules/accessibility/AXProgressIndicator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698