Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1245)

Unified Diff: Source/modules/accessibility/AXListBoxOption.cpp

Issue 1088853003: Implements determineAccessibilityRole() instead of roleValue() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/accessibility/AXListBoxOption.h ('k') | Source/modules/accessibility/AXMenuList.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/accessibility/AXListBoxOption.cpp
diff --git a/Source/modules/accessibility/AXListBoxOption.cpp b/Source/modules/accessibility/AXListBoxOption.cpp
index ae3e4afc062ed7ef56f56429f8d4ca5289a46083..5523b767039796f28082b211fe95ce77d7845431 100644
--- a/Source/modules/accessibility/AXListBoxOption.cpp
+++ b/Source/modules/accessibility/AXListBoxOption.cpp
@@ -53,11 +53,10 @@ PassRefPtr<AXListBoxOption> AXListBoxOption::create(LayoutObject* layoutObject,
return adoptRef(new AXListBoxOption(layoutObject, axObjectCache));
}
-AccessibilityRole AXListBoxOption::roleValue() const
+AccessibilityRole AXListBoxOption::determineAccessibilityRole()
{
- AccessibilityRole ariaRole = ariaRoleAttribute();
- if (ariaRole != UnknownRole)
- return ariaRole;
+ if ((m_ariaRole = determineAriaRoleAttribute()) != UnknownRole)
+ return m_ariaRole;
// http://www.w3.org/TR/wai-aria/complete#presentation
// ARIA spec says that the presentation role causes a given element to be treated
« no previous file with comments | « Source/modules/accessibility/AXListBoxOption.h ('k') | Source/modules/accessibility/AXMenuList.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698