Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 1088083002: Revert of Force full GCwhenever CollectAllGarbage is meant to trigger a full GC. (Closed)

Created:
5 years, 8 months ago by Michael Achenbach
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Force full GCwhenever CollectAllGarbage is meant to trigger a full GC. (patchset #4 id:60001 of https://codereview.chromium.org/1082973003/) Reason for revert: [Sheriff] Breaks http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20debug/builds/3348 and maybe leads to timeouts/crashes on layout test bots: http://build.chromium.org/p/client.v8/builders/V8-Blink%20Linux%2064/builds/3002 Original issue's description: > Force full GC whenever CollectAllGarbage is meant to trigger a full GC. > > Add a finalize incremental marking mode for CollectAllGarbage to finalize incremental marking when incremental marking is in progress, but we want a full gc at a given CollectAllGarbage call site. > > Default mode for CollectAllGarbage is finalize incremental marking and perform a full GC. > > BUG= > > Committed: https://crrev.com/9c105f0940ba757364ac18fcdf649815ec5ab2d1 > Cr-Commit-Position: refs/heads/master@{#27831} TBR=ulan@chromium.org,hpayer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/301151545e2c16fd936216afc73007a880516fb3 Cr-Commit-Position: refs/heads/master@{#27834}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+226 lines, -237 lines) Patch
M src/heap/heap.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/heap/heap.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/heap/mark-compact.h View 2 chunks +0 lines, -6 lines 0 comments Download
M src/heap/mark-compact.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/heap/mark-compact-inl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-accessors.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-api.cc View 71 chunks +90 lines, -87 lines 0 comments Download
M test/cctest/test-api-interceptors.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-constantpool.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-cpu-profiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-debug.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/test-deoptimization.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-feedback-vector.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M test/cctest/test-heap.cc View 61 chunks +85 lines, -87 lines 0 comments Download
M test/cctest/test-heap-profiler.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/test-mark-compact.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-mementos.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-object-observe.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-serialize.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/test-symbols.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-threads.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-unboxed-doubles.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/test-weakmaps.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M test/cctest/test-weaksets.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M test/cctest/test-weaktypedarrays.cc View 7 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of Force full GCwhenever CollectAllGarbage is meant to trigger a full GC.
5 years, 8 months ago (2015-04-15 09:06:57 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1088083002/1
5 years, 8 months ago (2015-04-15 09:07:13 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-15 09:07:33 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 09:07:45 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/301151545e2c16fd936216afc73007a880516fb3
Cr-Commit-Position: refs/heads/master@{#27834}

Powered by Google App Engine
This is Rietveld 408576698