Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Side by Side Diff: test/cctest/test-mementos.cc

Issue 1088083002: Revert of Force full GCwhenever CollectAllGarbage is meant to trigger a full GC. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « test/cctest/test-mark-compact.cc ('k') | test/cctest/test-object-observe.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 18 matching lines...) Expand all
29 29
30 using namespace v8::internal; 30 using namespace v8::internal;
31 31
32 32
33 static void SetUpNewSpaceWithPoisonedMementoAtTop() { 33 static void SetUpNewSpaceWithPoisonedMementoAtTop() {
34 Isolate* isolate = CcTest::i_isolate(); 34 Isolate* isolate = CcTest::i_isolate();
35 Heap* heap = isolate->heap(); 35 Heap* heap = isolate->heap();
36 NewSpace* new_space = heap->new_space(); 36 NewSpace* new_space = heap->new_space();
37 37
38 // Make sure we can allocate some objects without causing a GC later. 38 // Make sure we can allocate some objects without causing a GC later.
39 heap->CollectAllGarbage(); 39 heap->CollectAllGarbage(Heap::kAbortIncrementalMarkingMask);
40 40
41 // Allocate a string, the GC may suspect a memento behind the string. 41 // Allocate a string, the GC may suspect a memento behind the string.
42 Handle<SeqOneByteString> string = 42 Handle<SeqOneByteString> string =
43 isolate->factory()->NewRawOneByteString(12).ToHandleChecked(); 43 isolate->factory()->NewRawOneByteString(12).ToHandleChecked();
44 CHECK(*string); 44 CHECK(*string);
45 45
46 // Create an allocation memento behind the string with a garbage allocation 46 // Create an allocation memento behind the string with a garbage allocation
47 // site pointer. 47 // site pointer.
48 AllocationMemento* memento = 48 AllocationMemento* memento =
49 reinterpret_cast<AllocationMemento*>(new_space->top() + kHeapObjectTag); 49 reinterpret_cast<AllocationMemento*>(new_space->top() + kHeapObjectTag);
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
112 AllocationMemento* memento = 112 AllocationMemento* memento =
113 reinterpret_cast<AllocationMemento*>(memento_address + kHeapObjectTag); 113 reinterpret_cast<AllocationMemento*>(memento_address + kHeapObjectTag);
114 CHECK_EQ(memento->map(), heap->allocation_memento_map()); 114 CHECK_EQ(memento->map(), heap->allocation_memento_map());
115 115
116 // Furthermore, how many mementos did we create? The count should match 116 // Furthermore, how many mementos did we create? The count should match
117 // call_count. Note, that mementos are allocated during the inobject slack 117 // call_count. Note, that mementos are allocated during the inobject slack
118 // tracking phase. 118 // tracking phase.
119 AllocationSite* site = memento->GetAllocationSite(); 119 AllocationSite* site = memento->GetAllocationSite();
120 CHECK_EQ(call_count, site->pretenure_create_count()->value()); 120 CHECK_EQ(call_count, site->pretenure_create_count()->value());
121 } 121 }
OLDNEW
« no previous file with comments | « test/cctest/test-mark-compact.cc ('k') | test/cctest/test-object-observe.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698