test/cctest/test-object-observe.cc - Issue 1088083002: Revert of Force full GCwhenever CollectAllGarbage is meant to trigger a full GC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-object-observe.cc

Issue 1088083002: Revert of Force full GCwhenever CollectAllGarbage is meant to trigger a full GC. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/cctest/test-object-observe.cc

diff --git a/test/cctest/test-object-observe.cc b/test/cctest/test-object-observe.cc

index abbf2b7a6c00496156bf0e4ab27efb78eae4af53..50e2230fbac82c6cea87264704b03e08726f7ba8 100644

--- a/test/cctest/test-object-observe.cc

+++ b/test/cctest/test-object-observe.cc

@@ -429,7 +429,7 @@

CHECK_EQ(1, NumberOfElements(callbackInfoMap));

CHECK_EQ(1, NumberOfElements(objectInfoMap));

CHECK_EQ(1, NumberOfElements(notifierObjectInfoMap));

- i_isolate->heap()->CollectAllGarbage();

+ i_isolate->heap()->CollectAllGarbage(i::Heap::kAbortIncrementalMarkingMask);

CHECK_EQ(0, NumberOfElements(callbackInfoMap));

CHECK_EQ(0, NumberOfElements(objectInfoMap));

CHECK_EQ(0, NumberOfElements(notifierObjectInfoMap));

@@ -682,7 +682,7 @@

// the first garbage collection but some of the maps have already

// been marked at that point. Therefore some of the maps are not

// collected until the second garbage collection.

- CcTest::heap()->CollectAllGarbage();

+ CcTest::heap()->CollectAllGarbage(i::Heap::kNoGCFlags);

CcTest::heap()->CollectAllGarbage(i::Heap::kMakeHeapIterableMask);

int count = GetGlobalObjectsCount();

#ifdef DEBUG

« no previous file with comments | « test/cctest/test-mementos.cc ('k') | test/cctest/test-serialize.cc » ('j') | no next file with comments »