Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Side by Side Diff: test/cctest/test-symbols.cc

Issue 1088083002: Revert of Force full GCwhenever CollectAllGarbage is meant to trigger a full GC. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « test/cctest/test-serialize.cc ('k') | test/cctest/test-threads.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
57 os << Brief(*symbols[i]) << "\n"; 57 os << Brief(*symbols[i]) << "\n";
58 #if OBJECT_PRINT 58 #if OBJECT_PRINT
59 symbols[i]->Print(os); 59 symbols[i]->Print(os);
60 #endif 60 #endif
61 #if VERIFY_HEAP 61 #if VERIFY_HEAP
62 symbols[i]->ObjectVerify(); 62 symbols[i]->ObjectVerify();
63 #endif 63 #endif
64 } 64 }
65 65
66 CcTest::heap()->CollectGarbage(i::NEW_SPACE); 66 CcTest::heap()->CollectGarbage(i::NEW_SPACE);
67 CcTest::heap()->CollectAllGarbage(); 67 CcTest::heap()->CollectAllGarbage(Heap::kNoGCFlags);
68 68
69 // All symbols should be distinct. 69 // All symbols should be distinct.
70 for (int i = 0; i < kNumSymbols; ++i) { 70 for (int i = 0; i < kNumSymbols; ++i) {
71 CHECK(symbols[i]->SameValue(*symbols[i])); 71 CHECK(symbols[i]->SameValue(*symbols[i]));
72 for (int j = i + 1; j < kNumSymbols; ++j) { 72 for (int j = i + 1; j < kNumSymbols; ++j) {
73 CHECK(!symbols[i]->SameValue(*symbols[j])); 73 CHECK(!symbols[i]->SameValue(*symbols[j]));
74 } 74 }
75 } 75 }
76 } 76 }
OLDNEW
« no previous file with comments | « test/cctest/test-serialize.cc ('k') | test/cctest/test-threads.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698