Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 1087323002: Implement caching in the tessellating path renderer, including strokes.

Created:
5 years, 8 months ago by Stephen White
Modified:
5 years, 4 months ago
Reviewers:
bsalomon_chromium
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Implement caching of stroked paths in the tessellating path renderer. This required plumbing through the original (unstroked) path and stroking info, in order to include it in the cache key for the stroked, tessellated path. BUG=skia:

Patch Set 1 #

Patch Set 2 : Update to ToT #

Patch Set 3 : Integrate SkPathRef listeners. Plumb through original GrStrokeInfo for caching. #

Patch Set 4 : Reuse vertex buffer if it's large enough; use tolerance instead of size in cache info #

Patch Set 5 : Update to ToT #

Patch Set 6 : Update to ToT #

Patch Set 7 : Update to ToT, Fix GrStrokeInfo lifetime #

Patch Set 8 : NULL -> nullptr #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -24 lines) Patch
M include/gpu/GrDrawContext.h View 1 2 3 4 5 6 7 2 chunks +6 lines, -2 lines 0 comments Download
M src/gpu/GrBlurUtils.cpp View 1 2 3 4 2 chunks +2 lines, -1 line 0 comments Download
M src/gpu/GrClipMaskManager.cpp View 1 2 3 4 5 6 7 3 chunks +6 lines, -0 lines 0 comments Download
M src/gpu/GrDrawContext.cpp View 1 2 3 4 5 6 4 chunks +9 lines, -3 lines 0 comments Download
M src/gpu/GrPathRenderer.h View 1 2 3 4 5 6 7 2 chunks +4 lines, -0 lines 0 comments Download
M src/gpu/GrTessellatingPathRenderer.cpp View 1 2 3 4 5 6 7 8 chunks +31 lines, -18 lines 0 comments Download
M tests/TessellatingPathRendererTests.cpp View 1 2 3 4 5 6 7 1 chunk +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 1 (1 generated)
Stephen White
5 years, 4 months ago (2015-08-04 19:13:14 UTC) #1

Powered by Google App Engine
This is Rietveld 408576698