Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 1086113002: IDL: Improve "includes for type" mechanism in various ways (Closed)

Created:
5 years, 8 months ago by Jens Widell
Modified:
5 years, 8 months ago
Reviewers:
haraken, tasak
CC:
blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung, arv+blink, vivekg
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

IDL: Improve "includes for type" mechanism in various ways - Optionally pass extended attributes along with the type, so that the includes generated can depend on it. (This is not needed now, but will be in the future.) - Add includes for the types of method arguments, getters and setters. - Cleanup some (now) redundant calls to add_includes_for_type() in v8_types.py that interfered with the next item. - Don't add includes relating to "invisible" methods. Invisible methods are those that come from partial interfaces, and that won't actually be implemented in the compilation unit being generated. Adding such includes meant that files under bindings/core/ would sometimes include headers from bindings/modules/ (without depending on the contents of those headers). BUG=358074 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193787

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -30 lines) Patch
M Source/bindings/scripts/v8_attributes.py View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/scripts/v8_dictionary.py View 3 chunks +4 lines, -3 lines 0 comments Download
M Source/bindings/scripts/v8_interface.py View 3 chunks +5 lines, -3 lines 0 comments Download
M Source/bindings/scripts/v8_methods.py View 3 chunks +7 lines, -3 lines 0 comments Download
M Source/bindings/scripts/v8_types.py View 6 chunks +19 lines, -15 lines 0 comments Download
M Source/bindings/scripts/v8_union.py View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterface.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Jens Widell
PTAL tasak@: I don't know to what degree this actually helps the componentization effort, but ...
5 years, 8 months ago (2015-04-15 10:43:32 UTC) #2
haraken
Looks like a nice clean-up. LGTM.
5 years, 8 months ago (2015-04-15 11:03:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1086113002/1
5 years, 8 months ago (2015-04-15 11:33:31 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 12:58:01 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193787

Powered by Google App Engine
This is Rietveld 408576698