Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Unified Diff: Source/bindings/scripts/v8_interface.py

Issue 1086113002: IDL: Improve "includes for type" mechanism in various ways (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/scripts/v8_dictionary.py ('k') | Source/bindings/scripts/v8_methods.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/v8_interface.py
diff --git a/Source/bindings/scripts/v8_interface.py b/Source/bindings/scripts/v8_interface.py
index 4259ea804744c302754181cbb455893fe603a9ad..1e1bd83912a5de375739dec37d9ffac3873a37b4 100644
--- a/Source/bindings/scripts/v8_interface.py
+++ b/Source/bindings/scripts/v8_interface.py
@@ -1252,8 +1252,9 @@ def property_getter(getter, cpp_arguments):
return 'result.isEmpty()'
return ''
- idl_type = getter.idl_type
extended_attributes = getter.extended_attributes
+ idl_type = getter.idl_type
+ idl_type.add_includes_for_type(extended_attributes)
is_call_with_script_state = v8_utilities.has_extended_attribute_value(getter, 'CallWith', 'ScriptState')
is_raises_exception = 'RaisesException' in extended_attributes
use_output_parameter_for_result = idl_type.use_output_parameter_for_result
@@ -1296,8 +1297,9 @@ def property_setter(setter, interface):
if not setter:
return None
- idl_type = setter.arguments[1].idl_type
extended_attributes = setter.extended_attributes
+ idl_type = setter.arguments[1].idl_type
+ idl_type.add_includes_for_type(extended_attributes)
is_call_with_script_state = v8_utilities.has_extended_attribute_value(setter, 'CallWith', 'ScriptState')
is_raises_exception = 'RaisesException' in extended_attributes
@@ -1325,8 +1327,8 @@ def property_deleter(deleter):
if not deleter:
return None
- idl_type = deleter.idl_type
extended_attributes = deleter.extended_attributes
+ idl_type = deleter.idl_type
is_call_with_script_state = v8_utilities.has_extended_attribute_value(deleter, 'CallWith', 'ScriptState')
return {
'is_call_with_script_state': is_call_with_script_state,
« no previous file with comments | « Source/bindings/scripts/v8_dictionary.py ('k') | Source/bindings/scripts/v8_methods.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698