Source/bindings/scripts/v8_attributes.py - Issue 1086113002: IDL: Improve "includes for type" mechanism in various ways

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_attributes.py

Issue 1086113002: IDL: Improve "includes for type" mechanism in various ways (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/scripts/v8_attributes.py

diff --git a/Source/bindings/scripts/v8_attributes.py b/Source/bindings/scripts/v8_attributes.py

index c8b42f5bbfe407facefe6848dd6ade5467fab6db..bc8e77621e13046b176a90a57d90f9c0386ebc1f 100644

--- a/Source/bindings/scripts/v8_attributes.py

+++ b/Source/bindings/scripts/v8_attributes.py

@@ -49,7 +49,7 @@ def attribute_context(interface, attribute):

base_idl_type = idl_type.base_type

extended_attributes = attribute.extended_attributes

- idl_type.add_includes_for_type()

+ idl_type.add_includes_for_type(extended_attributes)

if idl_type.enum_values:

includes.add('core/inspector/ConsoleMessage.h')

« no previous file with comments | « no previous file | Source/bindings/scripts/v8_dictionary.py » ('j') | no next file with comments »