Source/bindings/scripts/v8_union.py - Issue 1086113002: IDL: Improve "includes for type" mechanism in various ways

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_union.py

Issue 1086113002: IDL: Improve "includes for type" mechanism in various ways (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/scripts/v8_union.py

diff --git a/Source/bindings/scripts/v8_union.py b/Source/bindings/scripts/v8_union.py

index 13b52cf3a183bf369623e77dcb5cbe2bd653d3a0..bf8c15d65bc0d50465426647171b501b2c896bf7 100644

--- a/Source/bindings/scripts/v8_union.py

+++ b/Source/bindings/scripts/v8_union.py

@@ -129,7 +129,7 @@ def container_context(union_type, interfaces_info):

def member_context(member, interfaces_info):

- cpp_includes.update(member.includes_for_type)

+ cpp_includes.update(member.includes_for_type())

interface_info = interfaces_info.get(member.name, None)

if interface_info:

cpp_includes.update(interface_info.get('dependencies_include_paths', []))

« no previous file with comments | « Source/bindings/scripts/v8_types.py ('k') | Source/bindings/tests/results/core/V8TestInterface.cpp » ('j') | no next file with comments »