Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1277)

Unified Diff: Source/modules/push_messaging/PushSubscription.cpp

Issue 1084683003: Merge the value of the push subscription id into the endpoint. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/push_messaging/PushSubscription.cpp
diff --git a/Source/modules/push_messaging/PushSubscription.cpp b/Source/modules/push_messaging/PushSubscription.cpp
index e7f8779035c5d113d8a08ec774dba76093ea92e6..ef09a4bf2b9df005a0b5efb4cb37dbff318dc7d6 100644
--- a/Source/modules/push_messaging/PushSubscription.cpp
+++ b/Source/modules/push_messaging/PushSubscription.cpp
@@ -40,6 +40,13 @@ PushSubscription::~PushSubscription()
{
}
+String PushSubscription::endpoint() const
+{
+ // TODO(peter): Remove all plumbing which separates the endpoint from the subscriptionId
+ // after the deprecation period has finished. https://crbug.com/477401.
+ return m_endpoint + "/" + m_subscriptionId;
+}
+
ScriptPromise PushSubscription::unsubscribe(ScriptState* scriptState)
{
RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);
@@ -55,8 +62,8 @@ ScriptPromise PushSubscription::unsubscribe(ScriptState* scriptState)
ScriptValue PushSubscription::toJSONForBinding(ScriptState* scriptState)
{
V8ObjectBuilder result(scriptState);
- result.addString("endpoint", m_endpoint);
- result.addString("subscriptionId", m_subscriptionId);
+ result.addString("endpoint", endpoint());
+ result.addString("subscriptionId", subscriptionId());
return result.scriptValue();
}
« no previous file with comments | « Source/modules/push_messaging/PushSubscription.h ('k') | Source/modules/push_messaging/PushSubscription.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698