Issue 1084423003: Merge 193840 "Service Worker: Add a test for error messages from..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1084423003: Merge 193840 "Service Worker: Add a test for error messages from..." (Closed)

Created:
5 years, 8 months ago by falken

Modified:
5 years, 8 months ago

Reviewers:
falken

CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, serviceworker-reviews, nhiroki, kinuko+serviceworker, horo+watch_chromium.org

Base URL:
svn://svn.chromium.org/blink/branches/chromium/2357/

Project:
blink

Visibility:
Public.

More Reviews

Description

Merge 193840 "Service Worker: Add a test for error messages from..." > Service Worker: Add a test for error messages from register() > > This tests existing behavior as well as some added in > https://codereview.chromium.org/1063823005 > > BUG=448003, 436928, 444296 > > Review URL: https://codereview.chromium.org/1058323004 TBR=falken@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193932

Patch Set 1 #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -4 lines)			Patch
A +	LayoutTests/http/tests/serviceworker/chromium/register-error-messages.html	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	LayoutTests/http/tests/serviceworker/registration.html	View	1 chunk	+12 lines, -3 lines	0 comments	Download
A +	LayoutTests/http/tests/serviceworker/resources/mime-type-worker.php	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	LayoutTests/http/tests/serviceworker/resources/plain-text-worker.php	View	1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as r193932.

Expand Messages | Collapse Messages