Service Worker: Use more specific errors when StartWorker fails

Service Worker: Use more specific errors when StartWorker fails

UMA shows StartWorker fails more than expected, but most errors are just
the generic START_WORKER_FAILED. Use a more specific error when appropriate.

This has some user-visible behavior change in the error message that register()
rejects with. For example, a syntax error used to fail with "ServiceWorker failed
to install"; now it fails with "ServiceWorker script evaluation failed".

A Blink layout test is added for error messages, which didn't have test
coverage previously.

BUG=448003
TEST=https://codereview.chromium.org/1058323004

Committed: https://crrev.com/9573d4d33bf81518dd38c732bd18bfb8851bb89a
Cr-Commit-Position: refs/heads/master@{#325261}

[falken, 2015-04-15 05:44:09]

falken@chromium.org changed reviewers:
+ nhiroki@chromium.org

[falken, 2015-04-15 05:44:09]

PTAL

[nhiroki, 2015-04-15 06:46:02]

LGTM

https://codereview.chromium.org/1063823005/diff/1/content/common/service_work...
File content/common/service_worker/service_worker_status_code.h (right):

https://codereview.chromium.org/1063823005/diff/1/content/common/service_work...
content/common/service_worker/service_worker_status_code.h:64:
SERVICE_WORKER_ERROR_SCRIPT_EVALUATE_FAILED,
Probably you need to update histograms.xml.

[falken, 2015-04-15 06:54:37]

https://codereview.chromium.org/1063823005/diff/1/content/common/service_work...
File content/common/service_worker/service_worker_status_code.h (right):

https://codereview.chromium.org/1063823005/diff/1/content/common/service_work...
content/common/service_worker/service_worker_status_code.h:64:
SERVICE_WORKER_ERROR_SCRIPT_EVALUATE_FAILED,
On 2015/04/15 06:46:02, nhiroki wrote:
> Probably you need to update histograms.xml.

Great point... done

[falken, 2015-04-15 06:58:40]

falken@chromium.org changed reviewers:
+ asvitkine@chromium.org, mkwst@chromium.org, peter@chromium.org

[falken, 2015-04-15 06:58:40]

adding OWNERS...
asvitkine: histogram
peter: push
mkwst: notifications

[Mike West, 2015-04-15 07:05:30]

notifications LGTM.

[Peter Beverloo, 2015-04-15 11:26:44]

On 2015/04/15 07:05:30, Mike West wrote:
> notifications LGTM.

push LGTM.

[Alexei Svitkine (slow), 2015-04-15 15:34:45]

lgtm

[falken, 2015-04-15 15:40:38]

The CQ bit was checked by falken@chromium.org

[falken, 2015-04-15 15:40:39]

The patchset sent to the CQ was uploaded after l-g-t-m from nhiroki@chromium.org
Link to the patchset: https://codereview.chromium.org/1063823005/#ps20001
(title: "update histograms.xml")

[commit-bot: I haz the power, 2015-04-15 15:41:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1063823005/20001

[commit-bot: I haz the power, 2015-04-15 16:49:58]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-04-15 16:50:49]

Patchset 2 (id:??) landed as
https://crrev.com/9573d4d33bf81518dd38c732bd18bfb8851bb89a
Cr-Commit-Position: refs/heads/master@{#325261}