Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1058323004: Service Worker: Add a test for error messages from register() (Closed)

Created:
5 years, 8 months ago by falken
Modified:
5 years, 8 months ago
Reviewers:
nhiroki
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Service Worker: Add a test for error messages from register() This tests existing behavior as well as some added in https://codereview.chromium.org/1063823005 BUG=448003, 436928, 444296 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193840

Patch Set 1 #

Total comments: 2

Patch Set 2 : rm unused ffile #

Patch Set 3 : line wrap #

Unified diffs Side-by-side diffs Delta from patch set Stats (+180 lines, -6 lines) Patch
A LayoutTests/http/tests/serviceworker/chromium/register-error-messages.html View 1 2 1 chunk +159 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/registration.html View 1 chunk +12 lines, -3 lines 0 comments Download
A LayoutTests/http/tests/serviceworker/resources/mime-type-worker.php View 1 chunk +9 lines, -0 lines 0 comments Download
D LayoutTests/http/tests/serviceworker/resources/plain-text-worker.php View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
falken
5 years, 8 months ago (2015-04-15 05:44:49 UTC) #2
nhiroki
lgtm https://codereview.chromium.org/1058323004/diff/1/LayoutTests/http/tests/serviceworker/chromium/resources/register-error-messages-worker.php File LayoutTests/http/tests/serviceworker/chromium/resources/register-error-messages-worker.php (right): https://codereview.chromium.org/1058323004/diff/1/LayoutTests/http/tests/serviceworker/chromium/resources/register-error-messages-worker.php#newcode7 LayoutTests/http/tests/serviceworker/chromium/resources/register-error-messages-worker.php:7: Who uses this file?
5 years, 8 months ago (2015-04-15 07:23:31 UTC) #3
falken
thanks https://codereview.chromium.org/1058323004/diff/1/LayoutTests/http/tests/serviceworker/chromium/resources/register-error-messages-worker.php File LayoutTests/http/tests/serviceworker/chromium/resources/register-error-messages-worker.php (right): https://codereview.chromium.org/1058323004/diff/1/LayoutTests/http/tests/serviceworker/chromium/resources/register-error-messages-worker.php#newcode7 LayoutTests/http/tests/serviceworker/chromium/resources/register-error-messages-worker.php:7: On 2015/04/15 07:23:31, nhiroki wrote: > Who uses ...
5 years, 8 months ago (2015-04-15 08:17:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1058323004/40001
5 years, 8 months ago (2015-04-16 00:22:11 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 01:49:13 UTC) #8
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193840

Powered by Google App Engine
This is Rietveld 408576698