Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1083133002: Rename GrStencilBuffer to GrStencilAttachment (Closed)

Created:
5 years, 8 months ago by egdaniel
Modified:
5 years, 8 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Rename GrStencilBuffer to GrStencilAttachment BUG=skia: Committed: https://skia.googlesource.com/skia/+/8dc7c3a839b38b73af34cc2674a06f49eb1ce527

Patch Set 1 #

Patch Set 2 : Rename function #

Patch Set 3 : line formatting #

Total comments: 1

Patch Set 4 : Variable and function name changes #

Patch Set 5 : Align data member #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -341 lines) Patch
M gyp/gpu.gypi View 2 chunks +4 lines, -4 lines 0 comments Download
M include/gpu/GrRenderTarget.h View 1 2 3 4 3 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/GrClipMaskManager.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrClipMaskManager.cpp View 1 2 3 5 chunks +12 lines, -12 lines 0 comments Download
M src/gpu/GrContext.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrDrawTarget.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrDrawTarget.cpp View 1 2 3 4 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/GrGpu.h View 1 2 3 6 chunks +8 lines, -8 lines 0 comments Download
M src/gpu/GrGpu.cpp View 1 2 3 5 chunks +10 lines, -10 lines 0 comments Download
M src/gpu/GrRenderTarget.cpp View 1 2 3 2 chunks +10 lines, -10 lines 0 comments Download
M src/gpu/GrRenderTargetPriv.h View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
A + src/gpu/GrStencilAttachment.h View 1 2 3 chunks +9 lines, -8 lines 0 comments Download
A + src/gpu/GrStencilAttachment.cpp View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
D src/gpu/GrStencilBuffer.h View 1 chunk +0 lines, -80 lines 0 comments Download
D src/gpu/GrStencilBuffer.cpp View 1 chunk +0 lines, -19 lines 0 comments Download
M src/gpu/GrTest.cpp View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLCaps.h View 4 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLGpu.h View 1 2 3 2 chunks +4 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 1 2 3 9 chunks +19 lines, -19 lines 0 comments Download
A + src/gpu/gl/GrGLStencilAttachment.h View 3 chunks +7 lines, -7 lines 0 comments Download
A + src/gpu/gl/GrGLStencilAttachment.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
D src/gpu/gl/GrGLStencilBuffer.h View 1 chunk +0 lines, -66 lines 0 comments Download
D src/gpu/gl/GrGLStencilBuffer.cpp View 1 chunk +0 lines, -35 lines 0 comments Download
M tests/ResourceCacheTest.cpp View 1 2 3 5 chunks +31 lines, -28 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
egdaniel
5 years, 8 months ago (2015-04-14 19:03:40 UTC) #2
bsalomon
I commented on one, but there are a bunch of vars named stencilBuffer, fStencilBuffer, etc. ...
5 years, 8 months ago (2015-04-14 19:39:01 UTC) #3
egdaniel
updated variable names
5 years, 8 months ago (2015-04-15 18:02:32 UTC) #4
bsalomon
On 2015/04/15 18:02:32, egdaniel wrote: > updated variable names lgtm
5 years, 8 months ago (2015-04-16 14:01:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1083133002/80001
5 years, 8 months ago (2015-04-16 18:06:42 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 18:22:46 UTC) #8
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/8dc7c3a839b38b73af34cc2674a06f49eb1ce527

Powered by Google App Engine
This is Rietveld 408576698