Source/core/html/track/TextTrackCue.h - Issue 108313015: Make calls to AtomicString(const String&) explicit in html/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/track/TextTrackCue.h

Issue 108313015: Make calls to AtomicString(const String&) explicit in html/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Take feedback into consideration Created 6 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/html/parser/AtomicHTMLToken.h ('K') | « Source/core/html/shadow/DateTimeFieldElement.cpp ('k') | Source/core/html/track/TextTrackCue.cpp » ('j') | Source/core/svg/SVGTests.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/track/TextTrackCue.h

diff --git a/Source/core/html/track/TextTrackCue.h b/Source/core/html/track/TextTrackCue.h

index 1779e37a7d1caae6c88bfe3e3195e3cbfeea8a93..6e9da464f62da307c13f7bfed9f98009ac32a63d 100644

--- a/Source/core/html/track/TextTrackCue.h

+++ b/Source/core/html/track/TextTrackCue.h

@@ -56,8 +56,8 @@ public:

TextTrack* track() const;

void setTrack(TextTrack*);

- const String& id() const { return m_id; }

- void setId(const String&);

+ const AtomicString& id() const { return m_id; }

+ void setId(const AtomicString&);

double startTime() const { return m_startTime; }

void setStartTime(double, ExceptionState&);

@@ -101,7 +101,7 @@ protected:

virtual void cueDidChange();

private:

- String m_id;

+ AtomicString m_id;

double m_startTime;

double m_endTime;

int m_cueIndex;