Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1816)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: Source/core/svg/SVGTests.cpp

Issue 108313015: Make calls to AtomicString(const String&) explicit in html/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Take feedback into consideration Created 6 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« Source/core/html/parser/AtomicHTMLToken.h ('K') | « Source/core/html/track/vtt/VTTParser.cpp ('k') | Source/core/testing/Internals.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/SVGTests.cpp
diff --git a/Source/core/svg/SVGTests.cpp b/Source/core/svg/SVGTests.cpp
index 1332610788d601c9803961b9dfb1127056260a33..add25eb087d2ae7ba3dd8657a670434573148f7b 100644
--- a/Source/core/svg/SVGTests.cpp
+++ b/Source/core/svg/SVGTests.cpp
@@ -110,7 +110,7 @@ bool SVGTests::isValid() const
unsigned systemLanguageSize = m_systemLanguage.value.size();
for (unsigned i = 0; i < systemLanguageSize; ++i) {
String value = m_systemLanguage.value.at(i);
- if (value != defaultLanguage().substring(0, 2))
+ if (value != defaultLanguage().string().substring(0, 2))
eseidel 2014/01/02 19:18:28 AtomicString might need substring() too. not sure
return false;
}
« Source/core/html/parser/AtomicHTMLToken.h ('K') | « Source/core/html/track/vtt/VTTParser.cpp ('k') | Source/core/testing/Internals.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698