Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: Source/core/html/track/TextTrackCue.h

Issue 108313015: Make calls to AtomicString(const String&) explicit in html/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Take feedback into consideration Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * Copyright (C) 2012, 2013 Apple Inc. All rights reserved. 3 * Copyright (C) 2012, 2013 Apple Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
49 { 49 {
50 DEFINE_STATIC_LOCAL(const AtomicString, cue, ("cue", AtomicString::Const ructFromLiteral)); 50 DEFINE_STATIC_LOCAL(const AtomicString, cue, ("cue", AtomicString::Const ructFromLiteral));
51 return cue; 51 return cue;
52 } 52 }
53 53
54 virtual ~TextTrackCue() { } 54 virtual ~TextTrackCue() { }
55 55
56 TextTrack* track() const; 56 TextTrack* track() const;
57 void setTrack(TextTrack*); 57 void setTrack(TextTrack*);
58 58
59 const String& id() const { return m_id; } 59 const AtomicString& id() const { return m_id; }
60 void setId(const String&); 60 void setId(const AtomicString&);
61 61
62 double startTime() const { return m_startTime; } 62 double startTime() const { return m_startTime; }
63 void setStartTime(double, ExceptionState&); 63 void setStartTime(double, ExceptionState&);
64 64
65 double endTime() const { return m_endTime; } 65 double endTime() const { return m_endTime; }
66 void setEndTime(double, ExceptionState&); 66 void setEndTime(double, ExceptionState&);
67 67
68 bool pauseOnExit() const { return m_pauseOnExit; } 68 bool pauseOnExit() const { return m_pauseOnExit; }
69 void setPauseOnExit(bool); 69 void setPauseOnExit(bool);
70 70
(...skipping 23 matching lines...) Expand all
94 DEFINE_ATTRIBUTE_EVENT_LISTENER(enter); 94 DEFINE_ATTRIBUTE_EVENT_LISTENER(enter);
95 DEFINE_ATTRIBUTE_EVENT_LISTENER(exit); 95 DEFINE_ATTRIBUTE_EVENT_LISTENER(exit);
96 96
97 protected: 97 protected:
98 TextTrackCue(double start, double end); 98 TextTrackCue(double start, double end);
99 99
100 void cueWillChange(); 100 void cueWillChange();
101 virtual void cueDidChange(); 101 virtual void cueDidChange();
102 102
103 private: 103 private:
104 String m_id; 104 AtomicString m_id;
105 double m_startTime; 105 double m_startTime;
106 double m_endTime; 106 double m_endTime;
107 int m_cueIndex; 107 int m_cueIndex;
108 108
109 TextTrack* m_track; 109 TextTrack* m_track;
110 110
111 bool m_isActive : 1; 111 bool m_isActive : 1;
112 bool m_pauseOnExit : 1; 112 bool m_pauseOnExit : 1;
113 }; 113 };
114 114
115 } // namespace WebCore 115 } // namespace WebCore
116 116
117 #endif 117 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698