Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1084)

Unified Diff: Source/core/html/parser/AtomicHTMLToken.h

Issue 108313015: Make calls to AtomicString(const String&) explicit in html/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Take feedback into consideration Created 6 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/parser/AtomicHTMLToken.h
diff --git a/Source/core/html/parser/AtomicHTMLToken.h b/Source/core/html/parser/AtomicHTMLToken.h
index 63e8c0c86dc3af3a795479c88d4e682624e8662b..886fd54988ddd715c9d2221adf15663fb6283851 100644
--- a/Source/core/html/parser/AtomicHTMLToken.h
+++ b/Source/core/html/parser/AtomicHTMLToken.h
@@ -150,7 +150,7 @@ public:
ASSERT_NOT_REACHED();
break;
case HTMLToken::DOCTYPE:
- m_name = token.data();
+ m_name = AtomicString(token.data());
m_doctypeData = adoptPtr(new DoctypeData());
m_doctypeData->m_hasPublicIdentifier = true;
append(m_doctypeData->m_publicIdentifier, token.publicIdentifier());
@@ -163,15 +163,15 @@ public:
case HTMLToken::StartTag:
m_attributes.reserveInitialCapacity(token.attributes().size());
for (Vector<CompactHTMLToken::Attribute>::const_iterator it = token.attributes().begin(); it != token.attributes().end(); ++it) {
- QualifiedName name(nullAtom, it->name, nullAtom);
+ QualifiedName name(nullAtom, AtomicString(it->name), nullAtom);
// FIXME: This is N^2 for the number of attributes.
eseidel 2014/01/02 19:18:28 I love that this has still never shown up on any b
if (!findAttributeInVector(m_attributes, name))
- m_attributes.append(Attribute(name, it->value));
+ m_attributes.append(Attribute(name, AtomicString(it->value)));
}
// Fall through!
case HTMLToken::EndTag:
m_selfClosing = token.selfClosing();
- m_name = token.data();
+ m_name = AtomicString(token.data());
break;
case HTMLToken::Character:
case HTMLToken::Comment:

Powered by Google App Engine
This is Rietveld 408576698