Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Issue 1083083007: Substitued pattern push_back(ptr.release()) with push_back(ptr.Pass()) (Closed)

Created:
5 years, 8 months ago by xtreit
Modified:
5 years, 7 months ago
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Substitued pattern push_back(ptr.release()) with push_back(ptr.Pass()) in the following directories: chrome/browser/password_manager components/password_manager BUG=457697 Committed: https://crrev.com/7c6fe3a4d16ee92dd0bf1c6b08337b4f8e962aa7 Cr-Commit-Position: refs/heads/master@{#326798}

Patch Set 1 : release Pass substitution #

Messages

Total messages: 11 (3 generated)
xtreit
5 years, 8 months ago (2015-04-24 02:44:55 UTC) #2
xtreit
5 years, 8 months ago (2015-04-24 02:47:33 UTC) #3
vabr (Chromium)
Thanks! The code LGTM, and I also followed the steps from https://www.chromium.org/developers/contributing-code/external-contributor-checklist to verify that ...
5 years, 8 months ago (2015-04-24 10:58:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1083083007/1
5 years, 8 months ago (2015-04-24 14:29:13 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-24 15:06:38 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7c6fe3a4d16ee92dd0bf1c6b08337b4f8e962aa7 Cr-Commit-Position: refs/heads/master@{#326798}
5 years, 8 months ago (2015-04-24 15:07:26 UTC) #8
d.samantaray
Hi, I have uploaded the patch. Please review. Issue created. URL: https://codereview.chromium.org/1125153
5 years, 7 months ago (2015-05-14 05:59:46 UTC) #10
d.samantaray
5 years, 7 months ago (2015-05-14 07:37:59 UTC) #11
Message was sent while issue was closed.
Hi 
Uploaded the patch. Please review. 
Issue created.URL:https://codereview.chromium.org/1138993007

Powered by Google App Engine
This is Rietveld 408576698