components/password_manager/core/browser/password_store_default_unittest.cc - Issue 1083083007: Substitued pattern push_back(ptr.release()) with push_back(ptr.Pass())

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_store_default_unittest.cc

Issue 1083083007: Substitued pattern push_back(ptr.release()) with push_back(ptr.Pass()) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: release Pass substitution Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/password_manager_unittest.cc ('k') | components/password_manager/core/browser/password_store_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_store_default_unittest.cc

diff --git a/components/password_manager/core/browser/password_store_default_unittest.cc b/components/password_manager/core/browser/password_store_default_unittest.cc

index 324b783202da0755d8df7357325b6e96527e0101..12ded5b61c6c2d59b03f58e8d4d4d60befdf9e3c 100644

--- a/components/password_manager/core/browser/password_store_default_unittest.cc

+++ b/components/password_manager/core/browser/password_store_default_unittest.cc

@@ -121,7 +121,7 @@ TEST_F(PasswordStoreDefaultTest, NonASCIIData) {

ScopedVector<PasswordForm> expected_forms;

for (unsigned int i = 0; i < arraysize(form_data); ++i) {

expected_forms.push_back(

- CreatePasswordFormFromDataForTesting(form_data[i]).release());

+ CreatePasswordFormFromDataForTesting(form_data[i]).Pass());

store->AddLogin(*expected_forms.back());

}