chrome/browser/password_manager/native_backend_libsecret.cc - Issue 1083083007: Substitued pattern push_back(ptr.release()) with push_back(ptr.Pass())

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/native_backend_libsecret.cc

Issue 1083083007: Substitued pattern push_back(ptr.release()) with push_back(ptr.Pass()) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: release Pass substitution Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/native_backend_kwallet_x.cc ('k') | chrome/browser/password_manager/password_store_x_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/native_backend_libsecret.cc

diff --git a/chrome/browser/password_manager/native_backend_libsecret.cc b/chrome/browser/password_manager/native_backend_libsecret.cc

index 72ecbad15b746d4326a93c75d41238e4f358e305..252af3d813ce097c9202f0a56151ca497734440a 100644

--- a/chrome/browser/password_manager/native_backend_libsecret.cc

+++ b/chrome/browser/password_manager/native_backend_libsecret.cc

@@ -601,7 +601,7 @@ ScopedVector<autofill::PasswordForm> NativeBackendLibsecret::ConvertFormList(

} else {

VLOG(1) << "Unable to access password from list element!";

}

- forms.push_back(form.release());

+ forms.push_back(form.Pass());

} else {

VLOG(1) << "Could not initialize PasswordForm from attributes!";

}