components/password_manager/core/browser/password_form_manager_unittest.cc - Issue 1083083007: Substitued pattern push_back(ptr.release()) with push_back(ptr.Pass())

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_form_manager_unittest.cc

Issue 1083083007: Substitued pattern push_back(ptr.release()) with push_back(ptr.Pass()) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: release Pass substitution Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/password_store_x_unittest.cc ('k') | components/password_manager/core/browser/password_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_form_manager_unittest.cc

diff --git a/components/password_manager/core/browser/password_form_manager_unittest.cc b/components/password_manager/core/browser/password_form_manager_unittest.cc

index 7a209082af3a3565836d53061e3baa0e1018b391..cdad6fe1b679de88825691bdbbea4b7f206b1405 100644

--- a/components/password_manager/core/browser/password_form_manager_unittest.cc

+++ b/components/password_manager/core/browser/password_form_manager_unittest.cc

@@ -970,7 +970,7 @@ TEST_F(PasswordFormManagerTest, TestUpdateIncompleteCredentials) {

// Feed the incomplete credentials to the manager.

ScopedVector<PasswordForm> simulated_results;

- simulated_results.push_back(incomplete_form.release());

+ simulated_results.push_back(incomplete_form.Pass());

form_manager.OnGetPasswordStoreResults(simulated_results.Pass());

form_manager.ProvisionallySave(

@@ -1372,7 +1372,7 @@ TEST_F(PasswordFormManagerTest, DriverDeletedBeforeStoreDone) {

client_with_store.KillDriver();

ScopedVector<PasswordForm> simulated_results;

- simulated_results.push_back(form.release());

+ simulated_results.push_back(form.Pass());

form_manager.OnGetPasswordStoreResults(simulated_results.Pass());

}