Remove children of title node before updating

Remove children of title node before updating

http://www.whatwg.org/specs/web-apps/current-work/multipage/dom.html#document.title

Extra care must be taken because of mutation events, which may cause
just about anything to happen including m_titleElement to be removed
itself when removing its children (see

LayoutTests/fast/dom/document-set-title-mutation-crash.html

for a good example). So make sure to again check m_titleElement before
actually setting the new title text.

Also update a related code comment that had rotted a bit.

Webkit bug: https://bugs.webkit.org/show_bug.cgi?id=28864

BUG=330140
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164228

[davve, 2013-12-20 09:01:10]

Patch takes some experience from the patch and (fails from) EWS results in the
Webkit bug.

[jochen (gone - plz use gerrit), 2013-12-20 09:12:42]

lgtm

can you please include a pointer to the webkit revision this is based on in the
CL desription?

[davve, 2013-12-20 09:16:03]

On 2013/12/20 09:12:42, jochen wrote:
> lgtm
> 
> can you please include a pointer to the webkit revision this is based on in
the
> CL desription?

Sorry, I was unclear. This hasn't been included in webkit, AFAIK. The bug is
still open. There was a patch, but it was rejected because of EWS fails.

[jochen (gone - plz use gerrit), 2013-12-20 09:18:20]

On 2013/12/20 09:16:03, David Vest wrote:
> On 2013/12/20 09:12:42, jochen wrote:
> > lgtm
> > 
> > can you please include a pointer to the webkit revision this is based on in
> the
> > CL desription?
> 
> Sorry, I was unclear. This hasn't been included in webkit, AFAIK. The bug is
> still open. There was a patch, but it was rejected because of EWS fails.

include a link to the bug then?

[davve, 2013-12-20 09:20:30]

On 2013/12/20 09:18:20, jochen wrote:
> On 2013/12/20 09:16:03, David Vest wrote:
> > On 2013/12/20 09:12:42, jochen wrote:
> > > lgtm
> > > 
> > > can you please include a pointer to the webkit revision this is based on
in
> > the
> > > CL desription?
> > 
> > Sorry, I was unclear. This hasn't been included in webkit, AFAIK. The bug is
> > still open. There was a patch, but it was rejected because of EWS fails.
> 
> include a link to the bug then?

Sure. I linked it in the chromium bug, but having in the description is
worthwhile too.

[davve, 2013-12-20 10:00:05]

Still OK? Document::updateTitle does dispatchDidReceiveTitle which means that a
listener might gets a little confused when the title bounces back and forth.
I've updated the patch to first remove children (which might cause one
dispatchDidReceiveTitle to the empty string) and then do the real
Document::updateTitle() and a dispatchDidReceiveTitle to the new title.

[jochen (gone - plz use gerrit), 2013-12-20 10:06:16]

still lgtm

[commit-bot: I haz the power, 2013-12-20 11:16:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/davve@opera.com/107513013/20001

[commit-bot: I haz the power, 2013-12-20 11:23:19]

Change committed as 164228