Source/core/html/HTMLTitleElement.cpp - Issue 107513013: Remove children of title node before updating

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLTitleElement.cpp

Issue 107513013: Remove children of title node before updating (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: remove children before updateTitle for less title update dispatches Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/HTMLTitleElement.cpp

diff --git a/Source/core/html/HTMLTitleElement.cpp b/Source/core/html/HTMLTitleElement.cpp

index c9fdaedc0f204d62844c66a3a24ea116a22fa827..fc50fdc83c2fa64a66f3baf86492d44b4e87217b 100644

--- a/Source/core/html/HTMLTitleElement.cpp

+++ b/Source/core/html/HTMLTitleElement.cpp

@@ -92,7 +92,7 @@ void HTMLTitleElement::setText(const String &value)

else {

// We make a copy here because entity of "value" argument can be Document::m_title,

// which goes empty during removeChildren() invocation below,

- // which causes HTMLTitleElement::childrenChanged(), which ends up Document::setTitle().

+ // which causes HTMLTitleElement::childrenChanged(), which ends up in Document::setTitleElement().

String valueCopy(value);

if (numChildren > 0)

« no previous file with comments | « Source/core/dom/Document.cpp ('k') | no next file » | no next file with comments »